Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 3-way merge for dependency updates during backflow #4342

Open
2 tasks
premun opened this issue Jan 20, 2025 · 0 comments
Open
2 tasks

Implement 3-way merge for dependency updates during backflow #4342

premun opened this issue Jan 20, 2025 · 0 comments
Assignees

Comments

@premun
Copy link
Member

premun commented Jan 20, 2025

Context

The updates to the version files are a complicated problem because not only they can happen in the repo/VMR but a third source of truth are the backflow updates which bring in the asset versions that were just built.

During #4196, we implemented a naive strategy for conflict resolution of version files during backflows.
This strategy takes the versions from the target branch and updates it with current build's assets.
This means that any changes to the version files done in the VMR will be lost.
This is temporarily fine because the VMR is closed for changes and no changes to these file will occur.
However, we will need a proper solution so that changes can be done in either side.

Goal

  • Implement a better conflict resolution strategy which will understand the changes since the last sync that happened in the repo, the VMR and which ones are updated by the currently flowed BAR build.
  • Create test cases which will show various scenarios that can happen (dependencies being add/removed on one side or another). The base scenario to start from is the BackwardFlowConflictResolutionTest which describes the problem well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant