Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Artifact Signing on macOS and Linux #59766

Open
ellahathaway opened this issue Jan 8, 2025 · 2 comments · May be fixed by #59590
Open

Enable Artifact Signing on macOS and Linux #59766

ellahathaway opened this issue Jan 8, 2025 · 2 comments · May be fixed by #59590
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Comments

@ellahathaway
Copy link
Member

This issue was originally encompassed in #58445. I am moving it to this new issue for better clarity and tracking of the work that needs to be done.

Currently, aspnetcore builds on mac & linux, then shuttles those bits to Windows to sign using Arcade's SignTool. Now that there is support for signing directly on mac & linux with SignTool, aspnetcore builds should sign the artifacts on the build machines (eg if an artifact was built on mac, we should/can now sign it on a mac). In other words, we should alter aspnetcore to be more 'vertical'.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 8, 2025
@ellahathaway ellahathaway changed the title Sign Mac & Linux Artifacts on Native OSes Enable Artifact Signing on macOS and Linux Jan 8, 2025
@ellahathaway ellahathaway linked a pull request Jan 8, 2025 that will close this issue
Draft
@ellahathaway
Copy link
Member Author

This work is currently blocked. See #59590 (comment).

@wtgodbe - we spoke offline earlier about building aspnetcore on alpine via cross building it. Can you give me some more context on why you'd prefer to build aspnetcore, at the repo-level, on alpine vs cross building (eg in the VMR we use mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux-3.0-net9.0-cross-arm-alpine for a musl build)?

@ellahathaway ellahathaway mentioned this issue Jan 8, 2025
Closed
@wtgodbe
Copy link
Member

wtgodbe commented Jan 8, 2025

Can you give me some more context on why you'd prefer to build aspnetcore, at the repo-level, on alpine vs cross building (eg in the VMR we use mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux-3.0-net9.0-cross-arm-alpine for a musl build)?

As a general principle, I prefer building on the target OS rather than cross-building for it, in case there are unexpected/arcane target-specific build errors. If we think the Microbuild work is going to be delayed longer than we expected, I'm fine with cross-building in the interim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable signing on mac & linux ellahathaway/aspnetcore
2 participants
@wtgodbe @ellahathaway