Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExternalAccess.Razor breaks Roslyn layering rules #76674

Open
tmat opened this issue Jan 8, 2025 · 1 comment
Open

ExternalAccess.Razor breaks Roslyn layering rules #76674

tmat opened this issue Jan 8, 2025 · 1 comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead

Comments

@tmat
Copy link
Member

tmat commented Jan 8, 2025

Microsoft.CodeAnalysis.Remote.ServiceHub should not depend on EditorFeatures layer, but it does via EA.Razor:

Image
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 8, 2025
@tmat tmat changed the title ExternalAccess.Razor is breaking Roslyn layering ExternalAccess.Razor is breaking Roslyn layering rules Jan 8, 2025
@tmat tmat changed the title ExternalAccess.Razor is breaking Roslyn layering rules ExternalAccess.Razor breaks Roslyn layering rules Jan 8, 2025
@davidwengier
Copy link
Contributor

We need to split EA.Razor up into two different assemblies, one for EditorFeatures (and above) and one for everything else. This will be needed for cohosting in VS Code anyway.

FYI @phil-allen-msft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmat @davidwengier