Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Windows/x64: 2 FrozenDictionary Regressions on 1/29/2025 3:52:02 AM +00:00 #112159

Open
performanceautofiler bot opened this issue Feb 4, 2025 · 3 comments
Assignees
Labels
arch-x64 area-System.Collections os-windows runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark untriaged New issue has not been triaged by the area owner

Comments

@performanceautofiler
Copy link

Run Information

Name Value
Architecture x64
OS Windows 10.0.22631
Queue ViperWindows
Baseline 9b24fb60a19f62620ca1fc5e4eb2e3ae0b3b086d
Compare bfa02766bdde4657ddd1f734e274d43e6ba3c036
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Collections.Perf_SubstringFrozenDictionary

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
1.19 ms 1.29 ms 1.08 0.01 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Collections.Perf_SubstringFrozenDictionary*'

System.Collections.Perf_SubstringFrozenDictionary.ToFrozenDictionary(Count: 10000)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository


Run Information

Name Value
Architecture x64
OS Windows 10.0.22631
Queue ViperWindows
Baseline 9b24fb60a19f62620ca1fc5e4eb2e3ae0b3b086d
Compare bfa02766bdde4657ddd1f734e274d43e6ba3c036
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Collections.Perf_SingleCharFrozenDictionary

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
670.32 μs 769.51 μs 1.15 0.01 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Collections.Perf_SingleCharFrozenDictionary*'

System.Collections.Perf_SingleCharFrozenDictionary.ToFrozenDictionary(Count: 10000)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@LoopedBard3
Copy link
Member

Definitely seems to be something here with more than one platform showing the regression. Commit range: 21ab780...d9b7515, only commit that seems potentially impactful is #110827. Any thoughts on that possibility @AndyAyersMS?

@LoopedBard3 LoopedBard3 transferred this issue from dotnet/perf-autofiling-issues Feb 4, 2025
@LoopedBard3 LoopedBard3 changed the title [Perf] Windows/x64: 2 Regressions on 1/29/2025 3:52:02 AM +00:00 [Perf] Windows/x64: 2 FrozenDictionary Regressions on 1/29/2025 3:52:02 AM +00:00 Feb 4, 2025
@LoopedBard3 LoopedBard3 added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Feb 4, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

@jeffhandley
Copy link
Member

Assigned to @eiriktsarpalis for triage alongside #112236.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-x64 area-System.Collections os-windows runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark untriaged New issue has not been triaged by the area owner
Projects
None yet
Development

No branches or pull requests

3 participants