Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PipeWriterStream public, unsealed #30150

Open
Tratcher opened this issue Jul 5, 2019 · 1 comment
Open

Make PipeWriterStream public, unsealed #30150

Tratcher opened this issue Jul 5, 2019 · 1 comment
Labels
api-needs-work API needs work before it is approved, it is NOT ready for implementation area-System.IO.Pipelines backlog-cleanup-candidate An inactive issue that has been marked for automated closure. no-recent-activity
Milestone
Future

Comments

@Tratcher
Copy link
Member

Tratcher commented Jul 5, 2019

PipeWriterStream doesn't allow for any customization. For example, we wanted to add additional checks in Write but could not derive from PipeWriterStream because it is internal and sealed. We had to duplicate all of PipeWriterStream in order to augment it.

https://github.com/aspnet/AspNetCore/pull/11611/files#diff-6d1eaebe8ea91cbadd3f6585fecd9a2f

This may also apply to PipeReaderStream but we haven't had to argument that one yet.

@davidfowl
@msftgits msftgits transferred this issue from dotnet/corefx Feb 1, 2020
@msftgits msftgits added this to the 5.0 milestone Feb 1, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@BrennanConroy BrennanConroy modified the milestones: 5.0.0, Future Jul 8, 2020
@halter73 halter73 removed the untriaged New issue has not been triaged by the area owner label Jul 8, 2020
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of our issue cleanup automation.

@dotnet-policy-service dotnet-policy-service bot added backlog-cleanup-candidate An inactive issue that has been marked for automated closure. no-recent-activity labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api-needs-work API needs work before it is approved, it is NOT ready for implementation area-System.IO.Pipelines backlog-cleanup-candidate An inactive issue that has been marked for automated closure. no-recent-activity
Projects
None yet
Milestone
Future
Development

No branches or pull requests
5 participants
@halter73 @Tratcher @maryamariyan @BrennanConroy @msftgits