Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultPipeWriter and DefaultPipeReader should suport (short token) #30192

Open
davidfowl opened this issue Jul 9, 2019 · 2 comments
Open

DefaultPipeWriter and DefaultPipeReader should suport (short token) #30192

davidfowl opened this issue Jul 9, 2019 · 2 comments
Assignees
Labels
area-System.IO.Pipelines backlog-cleanup-candidate An inactive issue that has been marked for automated closure. no-recent-activity
Milestone

Comments

@davidfowl
Copy link
Member

The token can be used to block concurrent reads and writes using the token (as we as other general misuse). We should update the Pipe to support this.

@stephentoub
Copy link
Member

While this won't catch every misuse, it's proven to be really helpful in flagging most in APIs that take advantage of it, e.g. Channels, async enumerables (which get it via ManualResetValueTaskSourceCore that uses it), HttpClient's HTTP2 implementation, etc. I agree we should update Pipe to utilize it.

@msftgits msftgits transferred this issue from dotnet/corefx Feb 1, 2020
@msftgits msftgits added this to the 5.0 milestone Feb 1, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@BrennanConroy BrennanConroy modified the milestones: 5.0.0, Future Jul 8, 2020
@halter73 halter73 removed the untriaged New issue has not been triaged by the area owner label Jul 8, 2020
Copy link
Contributor

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of our issue cleanup automation.

@dotnet-policy-service dotnet-policy-service bot added backlog-cleanup-candidate An inactive issue that has been marked for automated closure. no-recent-activity labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.IO.Pipelines backlog-cleanup-candidate An inactive issue that has been marked for automated closure. no-recent-activity
Projects
None yet
Development

No branches or pull requests

6 participants