Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet-watch tests failing #40006

Open
dsplaisted opened this issue Apr 4, 2024 · 8 comments
Open

dotnet-watch tests failing #40006

dsplaisted opened this issue Apr 4, 2024 · 8 comments
Assignees
Labels
Milestone

Comments

@dsplaisted
Copy link
Member

dsplaisted commented Apr 4, 2024

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=629827
Build error leg or test failing: dotnet-watch.Tests.dll.1.WorkItemExecution
Pull request: #39888

Error Message

##[error].packages/microsoft.dotnet.helix.sdk/8.0.0-beta.24177.1/tools/Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(89,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item dotnet-watch.Tests.dll.1 in job 82728a56-9430-4356-ab82-1c21670792a7 has failed

{
  "ErrorMessage": "",
  "ErrorPattern": "Work item dotnet-watch\\.Tests\\.dll\\.1 in job [a-z0-9\\-]+ has failed",
  "BuildRetry": true,
  "ExcludeConsoleLog": true
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=629827
Error message validated: [Work item dotnet-watch\.Tests\.dll\.1 in job [a-z0-9\-]+ has failed]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 4/4/2024 9:51:10 AM UTC

Report

Build Definition Step Name Console log Pull Request
929172 dotnet/sdk 🟣 Run TestBuild Tests Log #46300
929739 dotnet/sdk Run TestBuild Tests Log #46308
929680 dotnet/sdk 🟣 Run TestBuild Tests Log #46259
928709 dotnet/sdk 🟣 Run FullFramework Tests Log #46183
928756 dotnet/sdk Run TestBuild Tests Log #46285
929217 dotnet/sdk 🟣 Run TestBuild Tests Log #46261
929407 dotnet/sdk 🟣 Run TestBuild Tests Log #46290
929143 dotnet/sdk Run TestBuild Tests Log #46298
929186 dotnet/sdk Run TestBuild Tests Log #46197
928809 dotnet/sdk Run TestBuild Tests Log #46286
928598 dotnet/sdk 🟣 Run TestBuild Tests Log #46275
928195 dotnet/sdk 🟣 Run TestBuild Tests Log #46244
928112 dotnet/sdk 🟣 Run TestBuild Tests Log #46261
927641 dotnet/sdk 🟣 Run TestBuild Tests Log #46184
927012 dotnet/sdk 🟣 Run TestBuild Tests Log #46250
927626 dotnet/sdk Run TestBuild Tests Log #46260
927509 dotnet/sdk 🟣 Run FullFramework Tests Log #46183
927208 dotnet/sdk 🟣 Run TestBuild Tests Log #46238
927075 dotnet/sdk 🟣 Run TestBuild Tests Log #46021
926917 dotnet/sdk Run TestBuild Tests Log #46248
926900 dotnet/sdk Run TestBuild Tests Log #46180
926765 dotnet/sdk 🟣 Run TestBuild Tests Log #46101
926743 dotnet/sdk 🟣 Run TestBuild Tests Log #46021
926664 dotnet/sdk 🟣 Run FullFramework Tests Log #46238
926028 dotnet/sdk Run TestBuild Tests Log #45969
925679 dotnet/sdk 🟣 Run TestBuild Tests Log #46063
925445 dotnet/sdk 🟣 Run TestBuild Tests Log #46214
925289 dotnet/sdk 🟣 Run FullFramework Tests Log #46164
925046 dotnet/sdk 🟣 Run FullFramework Tests Log #46183
924845 dotnet/sdk Run TestBuild Tests Log #46153
924843 dotnet/sdk Run TestBuild Tests Log #46200
924803 dotnet/sdk 🟣 Run TestBuild Tests Log #46191
924690 dotnet/sdk Run TestBuild Tests Log #46173
924703 dotnet/sdk Run TestBuild Tests Log #46180
924548 dotnet/sdk 🟣 Run TestBuild Tests Log #46186
924631 dotnet/sdk 🟣 Run TestBuild Tests Log #46063
924465 dotnet/sdk Run TestBuild Tests Log #46179
924466 dotnet/sdk Run TestBuild Tests Log #46100
924419 dotnet/sdk 🟣 Run TestBuild Tests Log #46178
924379 dotnet/sdk Run TestBuild Tests Log #46141
924261 dotnet/sdk Run FullFramework Tests Log #46004
924260 dotnet/sdk Run TestBuild Tests Log #46169
924106 dotnet/sdk 🟣 Run TestBuild Tests Log #45362
923981 dotnet/sdk 🟣 Run TestBuild Tests Log #46129
923301 dotnet/sdk 🟣 Run TestBuild Tests Log #46142
923662 dotnet/sdk 🟣 Run TestBuild Tests Log #46158
923607 dotnet/sdk Run TestBuild Tests Log #46155
923562 dotnet/sdk Run TestBuild Tests Log #46145
923505 dotnet/sdk Run TestBuild Tests Log #46002
919402 dotnet/sdk Run TestBuild Tests Log #46033
922434 dotnet/sdk Run FullFramework Tests Log #45997
922430 dotnet/sdk Run TestBuild Tests Log #46100
922156 dotnet/sdk 🟣 Run TestBuild Tests Log #45932
921547 dotnet/sdk Run TestBuild Tests Log #45880
921651 dotnet/sdk Run TestBuild Tests Log #46111
921430 dotnet/sdk Run FullFramework Tests Log #46100
921438 dotnet/sdk 🟣 Run TestBuild Tests Log #46011
920675 dotnet/sdk 🟣 Run TestBuild Tests Log #46021
921258 dotnet/sdk Run TestBuild Tests Log #46068
921223 dotnet/sdk 🟣 Run TestBuild Tests Log #46089
920824 dotnet/sdk Run FullFramework Tests Log #46086
920701 dotnet/sdk 🟣 Run TestBuild Tests Log #46026
919413 dotnet/sdk Run TestBuild Tests Log #46034
920317 dotnet/sdk Run TestBuild Tests Log #46066
920181 dotnet/sdk 🟣 Run FullFramework Tests Log #46036
919906 dotnet/sdk 🟣 Run TestBuild Tests Log #46048
919623 dotnet/sdk Run TestBuild Tests Log #46042
919622 dotnet/sdk Run TestBuild Tests Log #46041
919581 dotnet/sdk 🟣 Run TestBuild Tests Log #46044
919388 dotnet/sdk Run TestBuild Tests Log #46030
919372 dotnet/sdk 🟣 Run TestBuild Tests Log #46026
919400 dotnet/sdk Run TestBuild Tests Log #46032
919342 dotnet/sdk 🟣 Run TestBuild Tests Log #46021
919158 dotnet/sdk 🟣 Run TestBuild Tests Log #45637
918736 dotnet/sdk 🟣 Run TestBuild Tests Log #42416
918497 dotnet/sdk 🟣 Run TestBuild Tests Log #45873
918546 dotnet/sdk 🟣 Run FullFramework Tests Log #45986
917975 dotnet/sdk 🟣 Run TestBuild Tests Log #45986
917952 dotnet/sdk 🟣 Run TestBuild Tests Log #45991
917565 dotnet/sdk 🟣 Run TestBuild Tests Log #45973
917843 dotnet/sdk Run TestBuild Tests Log #45369
917827 dotnet/sdk Run TestBuild Tests Log #45874
917669 dotnet/sdk 🟣 Run TestBuild Tests Log #45873
917465 dotnet/sdk Run TestBuild Tests Log #45969
917213 dotnet/sdk Run TestBuild Tests Log #45957
917133 dotnet/sdk 🟣 Run FullFramework Tests Log #45935
916376 dotnet/sdk Run TestBuild Tests Log #45369
916360 dotnet/sdk 🟣 Run TestBuild Tests Log #44611
916184 dotnet/sdk 🟣 Run TestBuild Tests Log #45873
916347 dotnet/sdk 🟣 Run TestBuild Tests Log #44761
915803 dotnet/sdk Run TestBuild Tests Log #45345
915808 dotnet/sdk Run FullFramework Tests Log #45930
915792 dotnet/sdk Run TestBuild Tests Log #45520
915552 dotnet/sdk Run TestBuild Tests Log #45874
914504 dotnet/sdk 🟣 Run TestBuild Tests Log #42416
914418 dotnet/sdk Run TestBuild Tests Log #45902
914283 dotnet/sdk 🟣 Run TestBuild Tests Log #45900
913860 dotnet/sdk 🟣 Run TestBuild Tests Log #45873
913850 dotnet/sdk 🟣 Run TestBuild Tests Log #45879
913374 dotnet/sdk 🟣 Run TestBuild Tests Log #45864
Displaying 100 of 160 results

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
6 52 160
@marcpopMSFT
Copy link
Member

@tmat
Copy link
Member

tmat commented Jun 26, 2024

No luck yet. This might help: https://github.com/dotnet/sdk/blob/d45e40d665e647804de03d2b4eec2aae9c488cb5/test/dotnet-watch.Tests/xunit.runner.json

It will print out test info every 20 seconds a test is running.

@marcpopMSFT
Copy link
Member

@tmat another failure this morning shows a bunch of build processes for watch apps still running... https://helixre107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-sdk-refs-pull-41958-merge-84357342ee154a5088/dotnet-watch.Tests.dll.2/1/console.3dddc463.log?helixlogtype=result

@tmat
Copy link
Member

tmat commented Jul 3, 2024

Looks like that's in 8.0 branch. Porting test diagnostics from 9: #41963

@Forgind
Copy link
Member

Forgind commented Aug 26, 2024

This has been making one of my PRs fail today, so I looked into it a bit. Based on when this issue was created and which tests are failing, I suspect this PR:
#39618

I asked jasonmalinowski whether the MSBuildWorkspace is supposed to support F# because I'd found a code snippet that suggested that it shouldn't, and he said it doesn't and never did. Did that PR make us use MSBuildWorkspace in a different way than we had before?

@Forgind
Copy link
Member

Forgind commented Aug 26, 2024

The changes to HotReloadDotNetWatcher look most suspicious to me. It looks like a substantial change to how we call MSBuild.

@Forgind
Copy link
Member

Forgind commented Jan 18, 2025

Ping @tmat
This is still a serious pain point, currently preventing MSBuild from merging their code flow to 9.0.2xx. I already clicked rerun twice. I pointed to a PR that I think is likely to blame.

@tmat
Copy link
Member

tmat commented Jan 19, 2025

Fixes targeting 9.0.3xx: #45999, #46141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants