Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new authentication for GitHub #369

Closed
asmeurer opened this issue Jul 31, 2020 · 3 comments · Fixed by #373
Closed

Support new authentication for GitHub #369

asmeurer opened this issue Jul 31, 2020 · 3 comments · Fixed by #373

Comments

@asmeurer
Copy link
Member

Our GitHub authentication method is deprecated and will go away in November. See https://github.blog/2020-07-30-token-authentication-requirements-for-api-and-git-operations/ and https://twitter.com/patricktoomey/status/1289019204662972419. The simplest way is to have people generate a token, although we should try to do the localhost callback or device authorization flow if we can.
@peterjc
Copy link

peterjc commented Jul 31, 2020

Tokens provided via a TravisCI protected environment variable work well, see #349 - sadly I have not made time to finish that.

@asmeurer
Copy link
Member Author

asmeurer commented Aug 1, 2020

This is about doctr configure. As far as I know, the behavior of doctr deploy should continue to work as it currently is.

@asmeurer
Copy link
Member Author

So GitHub has dropped support. doctr configure now fails with invalid username or password even if you enter the correct password.

asmeurer added a commit that referenced this issue Nov 19, 2020
@asmeurer
Update doctr configure to use the device authorization flow
cd89c8b 
Authenticating with username and password no longer works, so this is required
to use doctr configure.

Fixes #369.
This was referenced Nov 19, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update doctr configure to use the device authorization flow drdoctr/doctr
2 participants
@peterjc @asmeurer