Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff hangs when comparing sequences with nil #3

Closed
pithyless opened this issue Mar 16, 2019 · 4 comments
Closed

Diff hangs when comparing sequences with nil #3

pithyless opened this issue Mar 16, 2019 · 4 comments

Comments

@pithyless
Copy link

I've submitted an issue (brentonashworth#9) and PR (brentonashworth#8) to upstream, but considering the repo has not been updated in 8 years - perhaps @frenata could merge this and cut a new release?

Releasing a new version should fix lambdaisland/deep-diff2#6.
@frenata
Copy link

frenata commented Mar 16, 2019

I'm very open to this -- we forked the library rather than vendor it so that we could fix some issues and contribute back.

@pithyless
Copy link
Author

@frenata I've submitted PR #4.

Let me know if there is anything more you need from my end.

@frenata
Copy link

frenata commented Mar 18, 2019

Merged and released 1.0.1 with the change, thanks.

@frenata frenata closed this as completed Mar 18, 2019
@pithyless
Copy link
Author

Awesome, thanks for the fast turnaround @frenata!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pithyless @frenata