From 787ca99f3c9b2bf6f9c094e1f7c296abd201c5a8 Mon Sep 17 00:00:00 2001
From: moana <moana@dusk.network>
Date: Thu, 23 May 2024 15:31:42 +0200
Subject: [PATCH] core: Fix `rkyv-impl` feature

Resolves #183
---
 .github/workflows/dusk_ci.yml | 14 ++++++++------
 core/CHANGELOG.md             |  5 +++++
 core/src/transaction.rs       |  2 +-
 3 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/dusk_ci.yml b/.github/workflows/dusk_ci.yml
index a6a4336..5236ce7 100644
--- a/.github/workflows/dusk_ci.yml
+++ b/.github/workflows/dusk_ci.yml
@@ -12,23 +12,25 @@ jobs:
     uses: dusk-network/.github/.github/workflows/code-analysis.yml@main
     with:
       clippy_default: false
-      clippy_args: --release -- -D warnings
+      clippy_args: --release --features=alloc -- -D warnings
 
   dusk_analyzer:
     name: Dusk Analyzer
     uses: dusk-network/.github/.github/workflows/dusk-analysis.yml@main
+    with:
+      test_flags: --features=rkyv-impl,alloc
 
-  test_core_std:
-    name: test core std
+  test_core:
+    name: test core
     uses: dusk-network/.github/.github/workflows/run-tests.yml@main
     with:
-      test_flags: -p phoenix-core --features alloc
+      test_flags: -p phoenix-core --features=alloc
 
   test_core_rkyv:
-    name: test core rkyv
+    name: test core rkyv compiles
     uses: dusk-network/.github/.github/workflows/run-tests.yml@main
     with:
-      test_flags: -p phoenix-core --features rkyv-impl
+      test_flags: -p phoenix-core --features=rkyv-impl,alloc --no-run
 
   test_circuits:
     name: test cirucits
diff --git a/core/CHANGELOG.md b/core/CHANGELOG.md
index 73b9c22..a5f0574 100644
--- a/core/CHANGELOG.md
+++ b/core/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+- Fix missing import for `rkyv-impl` feature [#183]
+
 ## [0.28.0] - 2024-05-22
 
 ### Added
@@ -311,6 +315,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Canonical implementation shielded by feature.
 
 <!-- ISSUES -->
+[#183]: https://github.com/dusk-network/phoenix/issues/183
 [#179]: https://github.com/dusk-network/phoenix/issues/179
 [#175]: https://github.com/dusk-network/phoenix/issues/175
 [#171]: https://github.com/dusk-network/phoenix/issues/171
diff --git a/core/src/transaction.rs b/core/src/transaction.rs
index 87b8e32..2d17c21 100644
--- a/core/src/transaction.rs
+++ b/core/src/transaction.rs
@@ -11,7 +11,7 @@ extern crate alloc;
 use alloc::vec::Vec;
 
 #[cfg(feature = "rkyv-impl")]
-use rkyv::{Archive, Deserialize};
+use rkyv::{Archive, Deserialize, Serialize};
 
 use dusk_bls12_381::BlsScalar;
 use dusk_bytes::{DeserializableSlice, Error as BytesError, Serializable};