Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in PHP 8.2/Increase test coverage #221

Open
RobjS opened this issue Sep 18, 2023 · 2 comments
Open

Bugs in PHP 8.2/Increase test coverage #221

RobjS opened this issue Sep 18, 2023 · 2 comments
Labels

Comments

@RobjS
Copy link
Contributor

RobjS commented Sep 18, 2023

A number of classes (e.g. the generators) have no test coverage. As a result, there are some commands that will throw errors in PHP 8.2 (e.g. whippet generate theme) as the errors were not surfaced by the test suite when we did the initial PHP 8.2 work. We should ensure we have test coverage (at least unit, if not integration) for all the codebase, to avoid this in future.

@RobjS RobjS changed the title Increase test coverage Bugs in PHP 8.2/Increase test coverage Sep 18, 2023
@RobjS RobjS mentioned this issue Sep 18, 2023
4 tasks
@snim2
Copy link
Contributor

snim2 commented Sep 18, 2023

This might also be an opportunity to remove some repeated code in the generators and extract it into a superclass

@snim2 snim2 added the bug label Sep 25, 2023
@snim2
Copy link
Contributor

snim2 commented Sep 26, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants