Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repeating ['themes', 'plugins'] everywhere is not DRY #70

Open
mallorydxw opened this issue Jul 22, 2016 · 1 comment · May be fixed by #224
Open

Repeating ['themes', 'plugins'] everywhere is not DRY #70

mallorydxw opened this issue Jul 22, 2016 · 1 comment · May be fixed by #224
Labels
enhancement module/dependencies refactoring

Comments

@mallorydxw
Copy link
Contributor

No description provided.

@mallorydxw mallorydxw mentioned this issue Jul 22, 2016
Merged
53 tasks
@snim2
Copy link
Contributor

snim2 commented Sep 18, 2023

I think we should probably leave this until we have migrated Whippet to v8+ on the hosting platform, so we can make a DependencyTypes enum.

snim2 added a commit that referenced this issue Sep 22, 2023
@snim2
Dependency types are not hard-coded literals
e122818 
Previously we hard-coded the list of dependency types wherever
we needed to use them. In order to manage language packs within
Whippet, we now need to add to the list of dependency types.
So, rather than have them scattered over the code, we now have
them in one place.

Once we have dropped PHP 7.4 support, we should really use an
enumeration here.

Fixes #70
@snim2 snim2 linked a pull request Sep 22, 2023 that will close this issue
Draft
4 tasks
snim2 added a commit that referenced this issue Nov 26, 2023
@snim2
Dependency types are not hard-coded literals
8703f26 
Previously we hard-coded the list of dependency types wherever
we needed to use them. In order to manage language packs within
Whippet, we now need to add to the list of dependency types.
So, rather than have them scattered over the code, we now have
them in one place.

Once we have dropped PHP 7.4 support, we should really use an
enumeration here.

Fixes #70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement module/dependencies refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Manage language packs for all dependency types dxw/whippet
2 participants
@snim2 @mallorydxw