-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notice: rework footer and cta sections #2146
Comments
We should rework notice, this should be done for all notices. We should rework cta/footer as well as in ebayui. |
Is this really a bug? Originally, the placement of various items was related to whether other items were present. I recall this being the desired effect by DS. We need to verify. |
Yes we have a lot of different ways to show things in notice that we tacked on. It needs a refactor |
Design needs to simplify all the patterns for this. We will try to get this for our next major but need design to simplify all the usecases before we can start this. |
CTA should be positioned under body on small screen in all cases, even when there is no dismiss button:
We can see that when there is a CTA with dismiss button, the CTA is positioned correctly.
When we replace the dismiss button with the CTA, the CTA loses the ability to go in the correct space under the body:
Even if trying to use just the
section-notice__cta
(not sure if this is the desired expectation - it is not clear from current docs or stories), there is a spacing issue on large screens:This behavior can be verified in current storybook: https://opensource.ebay.com/skin/storybook/?path=/story/skin-section-notice--information-with-button
The text was updated successfully, but these errors were encountered: