Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22532] readProxy no ACKNOWLEDGED status #5529

Open
1 task done
wangsirun opened this issue Dec 27, 2024 · 2 comments
Open
1 task done

[22532] readProxy no ACKNOWLEDGED status #5529

wangsirun opened this issue Dec 27, 2024 · 2 comments
Labels
in progress Issue or PR which is being reviewed

Comments

@wangsirun
Copy link

Is there an already existing issue for this?

  • I have searched the existing issues

Expected behavior

i can search any location set the readdProxy changes_for_reader_ element set status to ACKNOWLEDGED.
image
here,Sequence numbers before Base are set as Acknowledged.
but no element set Acknowledged. so , there is a bug to fix?

Current behavior

no where set the status Acknowledged

Steps to reproduce

just see code

Fast DDS version/commit

tag 3.1.1

Platform/Architecture

Ubuntu Focal 20.04 amd64

Transport layer

TCPv4

Additional context

No response

XML configuration file

No response

Relevant log output

No response

Network traffic capture

No response

@wangsirun wangsirun added the triage Issue pending classification label Dec 27, 2024
@wangsirun
Copy link
Author

There is no explicit attempt to set seq to ACK anywhere in the code.

@EugenioCollado
Copy link
Contributor

Hi @wangsirun,

In the latest versions, the memory management of changes has been improved. Instead of explicitly tracking all acknowledged changes, a low_mark is now used to indicate that all changes prior to it have been acknowledged. These older changes are subsequently removed since they are no longer useful.

As a result, the status ACKNOWLEDGED is no longer set explicitly, as this information would be redundant with the low_mark. This approach enhances efficiency by reducing unnecessary data handling.

That said, you're correct that there are still comparisons with the ACKNOWLEDGED state in the code, and these can indeed lead to confusion. To avoid further confusion and to eliminate unnecessary conditional statements about the ACKNOWLEDGED state, we plan to clean up the code and remove these comparisons in future releases. However, this is not a bug, as the current behavior of the software is the expected one.

Thank you for raising this issue, if you have further questions or concerns, feel free to share them. We appreciate your feedback!

@EugenioCollado EugenioCollado added to-do and removed triage Issue pending classification labels Dec 30, 2024
@Javgilavi Javgilavi added in progress Issue or PR which is being reviewed and removed to-do labels Jan 9, 2025
@Javgilavi Javgilavi changed the title readProxy no ACKNOWLEDGED status [22532] readProxy no ACKNOWLEDGED status Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Issue or PR which is being reviewed
Projects
None yet
Development

No branches or pull requests

3 participants