Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

float/double fields converted to string by xtypes_to_json when 0 #197

Open
mac-apt opened this issue Sep 1, 2023 · 1 comment
Open

float/double fields converted to string by xtypes_to_json when 0 #197

mac-apt opened this issue Sep 1, 2023 · 1 comment

Comments

@mac-apt
Copy link

mac-apt commented Sep 1, 2023

In this function float/double types get judged whether they should be converted to numerical or string JSON field according to result of std::isnormal. That causes zeroes to be converted to string also, and I don't see any reason for that. Is that a bug?

@mac-apt
Copy link
Author

mac-apt commented Sep 14, 2023

I've made a patch correcting this issue, feel free to use it.
zero_float.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant