Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The DefaultSubmodel has not default kind INSTANCE #145

Closed
emildinchev opened this issue Jul 6, 2023 · 5 comments
Closed

The DefaultSubmodel has not default kind INSTANCE #145

emildinchev opened this issue Jul 6, 2023 · 5 comments
Assignees
@sebbader-sap
Labels
bug Something isn't working V.1.0.0 Final Release V.1.0.0 following EF processes

Comments

@emildinchev
Copy link
Contributor

When you create a ned DefaultSubmodel and call getKind() you will get null
@sebbader-sap sebbader-sap self-assigned this Jul 6, 2023
@sebbader-sap sebbader-sap added bug Something isn't working V.1.0.0 Final Release V.1.0.0 following EF processes labels Jul 6, 2023
@mjacoby
Copy link
Contributor

mjacoby commented Jul 6, 2023

@sebbader-sap This reminds me of the issue of setting default values for some properties as defined in the specification in the constructor which we discussed some time ago. I am quite sure you implemented this feature in the generator, however, the latest code generated does not seem to have this.

Has this functionality somehow been lost or disabled?

@sebbader-sap
Copy link
Contributor

indeed. Most likely because my branch with this feature in the generator faced a lot of problems with the latest metamodel version, so I went back to a later state.

@sebbader-sap
Copy link
Contributor

Or I expect default information in the ontology, which I have added manually to the aas-specs ontology... Don't remember.

@sebbader-sap sebbader-sap moved this from 🆕 New to 🏗 In progress in Eclipse AAS4J Dev Jul 14, 2023
@sebbader-sap
Copy link
Contributor

see sap-contributions#3

@sebbader-sap sebbader-sap mentioned this issue Aug 21, 2023
Merged
@FrankSchnicke FrankSchnicke moved this from 🏗 In progress to 👀 In review in Eclipse AAS4J Dev Nov 7, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Eclipse AAS4J Dev Nov 23, 2023
@FrankSchnicke
Copy link
Contributor

Fixed with latest release milestone-04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebbader-sap sebbader-sap

Labels
bug Something isn't working V.1.0.0 Final Release V.1.0.0 following EF processes
Projects
Eclipse AAS4J Dev
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mjacoby @emildinchev @FrankSchnicke @sebbader-sap