Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnresolvedType#getDimensions uses uncompiled regex, resulting in 97% of memory allocated in Pattern.compile #323

Open
sddavis opened this issue Jan 21, 2025 · 2 comments

Comments

@sddavis
Copy link

sddavis commented Jan 21, 2025

UnresolvedType#getDimensions introduced in 6e79467 uses an uncompiled regex. After upgrading to a version with this change, my test suite allocates 97% of its memory - 98.2GB - in Pattern.compile calls from that method.

@kriegaex
Copy link
Contributor

Good catch, thank you very much. Without having studied the code in detail, a quick glance at the changeset seems to imply that this might be fixable by compiling the regex. An automated test reproducing and verifying the excessive memory consumption would be nice.

Please note my July 2024 message to the aspectj-users and aspectj-announce mailing lists regarding my situation as an AspectJ maintainer.

@sddavis
Copy link
Author

sddavis commented Jan 22, 2025

I'm afraid I won't have time to provide a test. But here's a screenshot of the profiler:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants