Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Incorrect Implementation of REST Interface in POST Methods (Submodel-Repository) #614

Open
geso02 opened this issue Feb 6, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@geso02
Copy link
Contributor

geso02 commented Feb 6, 2025

Describe the bug

In the SubmodelRepository implementation, the methods postSubmodelElementByPathSubmodelRepo and postSubmodelElementSubmodelRepo return a ResponseEntity. However, the current implementation only returns a 201 Created status without including the created SubmodelElement in the response body.

Since the return type is already defined as SubmodelElement, the current implementation does not comply with the specified API and should be corrected to include the created object in the response body.

postSubmodelElementByPathSubmodelRepo

postSubmodelElementSubmodelRepo

To Reproduce
Steps to reproduce the behavior:

  1. Post a submodel element
  2. Check the return value

BaSyx (please complete the following information):

  • BaSyx Version [ v2.0]
  • BaSyx SDK [ Java]
  • AAS Version [ DotAAS V3]

Screenshots
If applicable, add screenshots to help explain your problem.

Used Asset Administration files (.aasx/.json/.xml)
Please drop your AAS files here that were used when the bug was encountered.

BaSyx configuration
Provide details about the configuration you used. If possible, attach the configuration as a .zip file.

System (please complete the following information):

  • OS: [Linux]
  • CPU architecture: x86]
  • Version [master branch]
@geso02 geso02 added the bug Something isn't working label Feb 6, 2025
@github-project-automation github-project-automation bot moved this to To triage in Support Requests Feb 6, 2025
@geso02 geso02 self-assigned this Feb 6, 2025
geso02 added a commit to geso02/basyx-java-server-sdk that referenced this issue Feb 6, 2025
@geso02 geso02 moved this from To triage to In review in Support Requests Feb 6, 2025
@geso02 geso02 moved this from In review to In progress in Support Requests Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In progress
Development

No branches or pull requests

1 participant