Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Logical Step (decider) view an extension of debugger view #22

Open
dvojtise opened this issue Oct 10, 2019 · 0 comments
Open

make Logical Step (decider) view an extension of debugger view #22

dvojtise opened this issue Oct 10, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@dvojtise
Copy link
Contributor

Currenlty, the Logical Step view has a "user decider" strategy tha tis used to do some step by step

image

this is redundant with the debugger view; Additionally, when paused on a logical step decision (in the logical step view), the variable view is not available.

These 2 views should collaborate (ie. their underlying engine addon)

Proposal:
makes Logical step view an extension of the debugger view;
remove step by step decider
remove redundant pause/resume and stop button from Logical Step view

when clicking on "pause" button (the one from the debugger), this would stop the engine as usual (showing the stack with its last executed logical step and showing the variable view)
the Logical step view can now show the possible logical step. The step proposed by the decider strategy should be highlighted. (when paused, changing the strategy may change the proposed logical step)
The possible actions would then be:

  • step over ( from debugger UI): use the proposed logical step and pause to the next decision
  • step into: allows to stop before executing the specific actions of the logical step
  • run (from debugger UI): use proposed logical steps until a manual pause or breakpoint
  • double click on the logical step view on a logical step: use the user choice instead of the proposed one and pause on next decision

The stack view would display different information (similar to sequential)
bottom: the engine (selecting it allows to get the variable view)
middle: the previous logical step executed
top: in italic: the future action: either a decision (with a new icon and explicit text) or the logical step actions that are about to run (ie. already selected but not run yet) (this is similar to the breakpoints which stop because one of the actions has a target that has a breakpoint on it.

@dvojtise dvojtise added the enhancement New feature or request label Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant