From d4c494188060939d69d211adfde44c2441b5116b Mon Sep 17 00:00:00 2001 From: Erik Jaegervall Date: Tue, 19 Nov 2024 15:33:29 +0100 Subject: [PATCH] Adress review comment and update tests --- databroker/src/grpc/kuksa_val_v2/val.rs | 4 ++-- doc/protocol.md | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/databroker/src/grpc/kuksa_val_v2/val.rs b/databroker/src/grpc/kuksa_val_v2/val.rs index e86f5dd8..b0a64d41 100644 --- a/databroker/src/grpc/kuksa_val_v2/val.rs +++ b/databroker/src/grpc/kuksa_val_v2/val.rs @@ -2356,7 +2356,7 @@ mod tests { .await .map(|res| res.into_inner()) { - Ok(_) => {} + Ok(_) => {panic!("We shall not succeed with a blank before *")} Err(error) => { assert_eq!( error.code(), @@ -2385,7 +2385,7 @@ mod tests { .await .map(|res| res.into_inner()) { - Ok(_) => {} + Ok(_) => {panic!("Success not expected!")} Err(error) => { assert_eq!(error.code(), tonic::Code::NotFound, "unexpected error code"); assert_eq!( diff --git a/doc/protocol.md b/doc/protocol.md index ddd7cb68..eafe4b1f 100644 --- a/doc/protocol.md +++ b/doc/protocol.md @@ -23,7 +23,7 @@ This is an overview of the APIs supported described using the perspectives above | ------------------------ |-----|-----|-----|-----|-----|-----|-----|-----|-----| | gRPC (kuksa.val.v2) | Yes | Yes | Yes | No | No | No | Yes | No | Yes | gRPC (kuksa.val.v1) *Deprecated!* | Yes | Yes | Yes | Yes | Yes | Yes | No | No | No -| gRPC (sdv.databroker.v1) *Deprecated!* | Yes | Yes | Yes | Yes | Yes | Yes | No | No | No +| gRPC (sdv.databroker.v1) *Deprecated!* | Yes | Yes | Yes | Yes | No | No | No | No | No | VISS v2 | No | Yes | Yes | Yes | No | No | No | No | No In general it is possible to mix protocols in a deployment, as long as the difference concerning Target/Actuation values are observed.