-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipelining for Oracle Client #1434
base: master
Are you sure you want to change the base?
Pipelining for Oracle Client #1434
Conversation
I have implemented tests in #1434 1769e9f using PipeliningQueryTestBase.java. I'm facing this issue with this test case. In this test case, it prepares and executes different queries in a loop. It expects the prepare+execute operations to get executed in order. but with my implementation it doesn't get executed in order. Im trying to fix this issue |
@sudaraka94 how is going your investigation with the prepare+execute case ? |
Hello @vietj I sent you an email with the info, let me add it here as well. Right now I have implemented pipelining and tests (by extending PipeliningQueryTestBase). But there were a few test failures and I spent some time trying to understand why. But I think I might need some help in figuring out whether we should fix the tests or ignore them. Let me summarize the concerns I am having below,
|
fixes #1352
Motivation:
Since release 23C, Oracle started supporting pipelined operations (ref). This PR adds pipelined execution support for vertx-oracle-client
Conformance:
You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines