Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-triggering challenge notifications in CTF mode not consistent [🐛] #1088

Closed
bkimminich opened this issue Jun 5, 2019 · 2 comments · Fixed by Javi-DR/juice-shop#5, mnuma/juice-shop#23 or dantegia/juice-shop#5 · May be fixed by GustavoEsser/juice-shop#6 or akanchhaS/github-juice-shop-js#97
Closed

Re-triggering challenge notifications in CTF mode not consistent [🐛] #1088

bkimminich opened this issue Jun 5, 2019 · 2 comments · Fixed by Javi-DR/juice-shop#5, mnuma/juice-shop#23 or dantegia/juice-shop#5 · May be fixed by GustavoEsser/juice-shop#6 or akanchhaS/github-juice-shop-js#97
Labels
bug
Milestone
Open Security Sum...

Comments

@bkimminich
Copy link
Member

🐛 Bug report

Description

Running in NODE_ENV=ctf mode and clicking the "Solved"-button for a challenge to re-trigger its notification box, doesn't work consistently:

  1. Re-triggering the same notification that was last shown does not show the notification until the next F5 refresh
  2. Flipping between two or more challenges when re-triggering notifications makes them immediately appear
@bkimminich bkimminich added the bug label Jun 5, 2019
@bkimminich bkimminich changed the title [🐛] Re-triggering challenge notifications in CTF mode not consistent [🐛] Jun 5, 2019
bkimminich added a commit that referenced this issue Jun 5, 2019
@bkimminich
Enable challenge solved notification e2e test
f38a36e 
(might fail Travis-CI due to #1088)
@bkimminich bkimminich added this to the Open Security Summit 2019 milestone Jun 5, 2019
@J12934
Copy link
Member

J12934 commented Jun 5, 2019

Closed by #1089

@J12934 J12934 closed this as completed Jun 5, 2019
crispy-peppers pushed a commit to crispy-peppers/juice-shop that referenced this issue Nov 12, 2019
@MartinJM @ColdHeat
The place indicator on the team page now excludes counting hidden tea…
941ca8f 
…ms (juice-shop#1094)

* The place indicator in Team Mode on the team pages and user pages now excludes counting hidden teams.
* Updated `flask-marshmallow` to 0.10.1, `marshmallow-sqlalchemy` to 0.17.0 
* Pinned `marshmallow` to 2.20.2
* Closes juice-shop#1093
* Closes juice-shop#1088
@github-actions
Copy link

This thread has been automatically locked because it has not had recent activity after it was closed. 🔒 Please open a new issue for regressions or related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Open Security Summit 2019
2 participants
@bkimminich @J12934