Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS file #43

Conversation

e-pettersson-ericsson
Copy link
Member

@e-pettersson-ericsson e-pettersson-ericsson commented May 18, 2020

Applicable Issues

Fixes #7

Description of the Change

Add @eiffel-community/eiffel-community-maintainers as CODEOWNERS so that maintainers are automatically requested for reviews on new PR's. (probably won't see the change before merging this file)

Alternate Designs

Benefits

Quicker response from maintainers on code reviews.

In the future we might also consider to restrict merging of pullrrequests that does not have any review from a maintainer - this can be done in repository settings with the help of CODEOWNERS file.

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Emelie Pettersson [email protected]

Copy link
Member

@henning-roos henning-roos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@e-pettersson-ericsson e-pettersson-ericsson requested a review from a team May 18, 2020 09:24
@e-pettersson-ericsson e-pettersson-ericsson merged commit 1359291 into eiffel-community:master May 29, 2020
@e-pettersson-ericsson e-pettersson-ericsson deleted the add-codeowners-file branch May 29, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CODEOWNERS file to identify maintainers for Eiffel projects
3 participants