Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get eiffel JSON schemas from github instead #29

Open
t-persson opened this issue Jan 31, 2021 · 0 comments
Open

Get eiffel JSON schemas from github instead #29

t-persson opened this issue Jan 31, 2021 · 0 comments

Comments

@t-persson
Copy link
Collaborator

Description

Instead of hosting our own versions of the JSON schemas we should use the official schemas hosted on the eiffel repository.

Motivation

If a new version of an event is released and being sent, the eiffellib will not allow subscribers to that event.

Exemplification

The ArtifactCreated event gets updated from 4.0.0 to 4.0.1, a very minor release. A new version of the schema get published.
A publisher of that event starts publishing the 4.0.1 event, but the subscribers to that event do not update their eiffellib. This will mean that eiffellib will reject those events as there is no way to validate them.
In this case it was a very minor update and the subscribers would not be affected by the change, so it is quite annoying that eiffellib rejected it.

Benefits

Easier for subscribers of events to continue subscribing to that event, especially when there are only minor updates to the schemas.

Possible Drawbacks

Having to do HTTP requests, but the benefits of not having to update the entire chain on an eiffel specification update outweighs that completely.
Can be mitigated by having a cache in the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant