-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show dates default to en-GB?! #5
Comments
I’m having the exact same problem on multiple websites. Hope this is fixed soon. |
I am also experiencing this issue on https://thomashindsmedia.com/ |
I wonder if Component Shadowing could be used to work around this problem? Find/Replace all instances of en-GB with en-US? https://www.gatsbyjs.org/blog/2019-04-29-component-shadowing/ |
I've confirmed that simply shadowing "show-item.js" locally and changing en-GB to en-US does not fix the problem. Apparently it's more complex than that. |
I have no idea what that means...
…On Fri, Jan 3, 2020, 3:59 PM Charles Hood ***@***.***> wrote:
I've confirmed that simply shadowing "show-item.js" locally and changing
en-GB to en-US does not fix the problem. Apparently it's more complex than
that.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#5?email_source=notifications&email_token=AM6HKI77J7YTBDMDZOGZGR3Q36RMTA5CNFSM4J7BE6Z2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEICCGWA#issuecomment-570696536>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM6HKI5T36NLQOUGY5CC5SLQ36RMTANCNFSM4J7BE6ZQ>
.
|
Sorry, you could ignore that – – I was supposed to be logged in as me when I posted that bug report.
Thanks,
~C.H.
… On Jan 3, 2020, at 4:51 PM, thmshinds ***@***.***> wrote:
I have no idea what that means...
On Fri, Jan 3, 2020, 3:59 PM Charles Hood ***@***.***> wrote:
> I've confirmed that simply shadowing "show-item.js" locally and changing
> en-GB to en-US does not fix the problem. Apparently it's more complex than
> that.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#5?email_source=notifications&email_token=AM6HKI77J7YTBDMDZOGZGR3Q36RMTA5CNFSM4J7BE6Z2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEICCGWA#issuecomment-570696536>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AM6HKI5T36NLQOUGY5CC5SLQ36RMTANCNFSM4J7BE6ZQ>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Okay, first of all, Thanks to @TheRobBrennan for putting me on the right track! I did not implement the fix the same way he did, mine is more of a hack -- but I was able to use component shadowing, which is something I've been wanting to try. I created a src/gatsby-theme-musician/components/ folder and put my modified copy of show-item.js in there. (Again, based heavily on @TheRobBrennan 's work, but I am the lazy so I hardcoded mine to en-US. Here is the new show-item.js: /** @jsx jsx / const ShowItem = ({ id, name, date, location, info_url, map_url, locale }) => { export default ShowItem |
Eek. I can define show dates just fine in
shows.yml
but since I'm in Seattle, they need to be defined one day in the future since all dates are being represented asen-GB
locale strings.Can this be fixed?
The text was updated successfully, but these errors were encountered: