Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we bump the RueidisStore version to include 6177036c32a70117ce1cec95275edcb0b96d195e? #263

Open
lyonlai opened this issue Nov 15, 2024 · 0 comments

Comments

@lyonlai
Copy link

lyonlai commented Nov 15, 2024

Please describe the a concise description and fill out the details below. It will help others efficiently understand your request and get to an answer instead of repeated back and forth. Providing a minimal, complete and verifiable example will further increase your chances that someone can help.

Steps for Reproduction

I have the following setup. A marshaler => metric cache => cache with rueidis as the store. When setting a value, it throws out error interface conversion: interface {} is []uint8, not string. Digging into the code and found the rueidis store is trying to convert the input to a string.

marshaler.New(gocache.NewMetric[any](
			metrics.NewPrometheus("schema-registry", metrics.WithNamespace("cash_cache")),
			gocache.New[any](rueStore.NewRueidis(
				client,
				store.WithExpiration(24*time.Hour),
				store.WithClientSideCaching(4*time.Hour),
			))

I'm with gocache/store/rueidis/[email protected] at the moment. But I see 6177036c32a70117ce1cec95275edcb0b96d195e fixes this for me.

Expected behavior:

Expect it to have no error with marshaller.

Actual behavior:

interface conversion: interface {} is []uint8, not string

Platforms:

mac & linux

Versions:

4.1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant