From b68261361385664fa31b62dd54505d34d1ce45dd Mon Sep 17 00:00:00 2001 From: Elena Shostak Date: Thu, 2 Jan 2025 14:43:58 +0100 Subject: [PATCH] Tests --- .../src/versioned_router/core_versioned_route.test.ts | 9 +++------ .../server/routes/authentication/common.test.ts | 10 +++++++--- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/core/packages/http/router-server-internal/src/versioned_router/core_versioned_route.test.ts b/src/core/packages/http/router-server-internal/src/versioned_router/core_versioned_route.test.ts index c492ea1e20134..9c09de9e45895 100644 --- a/src/core/packages/http/router-server-internal/src/versioned_router/core_versioned_route.test.ts +++ b/src/core/packages/http/router-server-internal/src/versioned_router/core_versioned_route.test.ts @@ -542,22 +542,19 @@ describe('Versioned route', () => { authz: { requiredPrivileges: ['foo', 'bar', 'baz'], }, + authc: undefined, }; const securityConfig1: RouteSecurity = { authz: { requiredPrivileges: ['foo'], }, - authc: { - enabled: 'optional', - }, + authc: undefined, }; const securityConfig2: RouteSecurity = { authz: { requiredPrivileges: ['foo', 'bar'], }, - authc: { - enabled: true, - }, + authc: undefined, }; const versionedRoute = versionedRouter .get({ path: '/test/{id}', access: 'internal', security: securityConfigDefault }) diff --git a/x-pack/platform/plugins/shared/security/server/routes/authentication/common.test.ts b/x-pack/platform/plugins/shared/security/server/routes/authentication/common.test.ts index 0fd2c54a1e6ca..88b55f1801f69 100644 --- a/x-pack/platform/plugins/shared/security/server/routes/authentication/common.test.ts +++ b/x-pack/platform/plugins/shared/security/server/routes/authentication/common.test.ts @@ -6,8 +6,8 @@ */ import { Type } from '@kbn/config-schema'; -import type { RequestHandler, RouteConfig } from '@kbn/core/server'; import { kibanaResponseFactory } from '@kbn/core/server'; +import type { AuthzDisabled, RequestHandler, RouteConfig } from '@kbn/core/server'; import { coreMock, httpServerMock } from '@kbn/core/server/mocks'; import type { DeeplyMockedKeys } from '@kbn/utility-types-jest'; @@ -65,9 +65,11 @@ describe('Common authentication routes', () => { }); it('correctly defines route.', async () => { + expect(routeConfig.security?.authc?.enabled).toEqual(false); + expect((routeConfig.security?.authz as AuthzDisabled).enabled).toEqual(false); + expect(routeConfig.options).toEqual({ access: 'public', - authRequired: false, tags: [ROUTE_TAG_CAN_REDIRECT, ROUTE_TAG_AUTH_FLOW], excludeFromOAS: true, }); @@ -201,7 +203,9 @@ describe('Common authentication routes', () => { }); it('correctly defines route.', () => { - expect(routeConfig.options).toEqual({ authRequired: false }); + expect(routeConfig.security?.authc?.enabled).toEqual(false); + expect((routeConfig.security?.authz as AuthzDisabled).enabled).toEqual(false); + expect(routeConfig.validate).toEqual({ body: expect.any(Type), query: undefined,