Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console] Requests made to kbn: do not trigger deprecation counters #207868

Open
jloleysens opened this issue Jan 22, 2025 · 2 comments
Open

[Console] Requests made to kbn: do not trigger deprecation counters #207868

jloleysens opened this issue Jan 22, 2025 · 2 comments
Labels
discuss Feature:Console Dev Tools Console Feature Feature:http Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@jloleysens
Copy link
Contributor

jloleysens commented Jan 22, 2025 •
edited
Loading

In the fetch service (browser side) we always inject a header to flag a request as internal:

kibana/src/core/packages/http/browser-internal/src/fetch.ts

Line 143 in 8580f4f

[X_ELASTIC_INTERNAL_ORIGIN_REQUEST]: 'Kibana',

This breaks our ability to count deprecated usages from Console that go to deprecated Kibana routes. Perhaps this is OK, Console is not strictly "third party integration", but I think we should surface the deprecations in Console UI much like we do for ES deprecations (that are contained in the warn header).

We should be able to do this quite easily now that deprecations are returned for Kibana APIs too:

#205926
@jloleysens jloleysens added discuss Feature:Console Dev Tools Console Feature Feature:http Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Jan 22, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@jloleysens jloleysens changed the title [Console] Requests made to kbn: should not be counted as internal requests [Console] Requests made to kbn: do not trigger deprecation counters Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss Feature:Console Dev Tools Console Feature Feature:http Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jloleysens @elasticmachine