From 921e603f1c7c73dd1abbee863a24984336e66dfb Mon Sep 17 00:00:00 2001 From: Ry Biesemeyer Date: Fri, 8 Nov 2024 14:23:09 -0800 Subject: [PATCH 1/5] Add Known Issue for 8.15.x releases and PipelineBusV2 https://github.com/elastic/logstash/issues/16657 --- docs/static/releasenotes.asciidoc | 37 ++++++++++++++++++++++++++++++- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/docs/static/releasenotes.asciidoc b/docs/static/releasenotes.asciidoc index f4a40917f4a..c08b17ad08f 100644 --- a/docs/static/releasenotes.asciidoc +++ b/docs/static/releasenotes.asciidoc @@ -77,6 +77,11 @@ This section summarizes the changes in the following releases: * Fixed an issue where Logstash could not consume lines correctly when a codec with a delimiter is in use and the input buffer becomes full https://github.com/elastic/logstash/pull/16482[#16482] +[[known-issues-8-15-4]] +==== Known issues + +* {ls} can fail to shut down in some cases when using pipeline-to-pipeline. This can be avoided by setting `-Dlogstash.pipelinebus.implementation=v1` in `config/jvm.properties`, which reverts to using v1 of the `PipelineBus` that does not have this issue but may have performance impact in pipeline>pipeline scenarios. + [[dependencies-8.15.4]] ==== Updates to dependencies @@ -112,6 +117,14 @@ This section summarizes the changes in the following releases: * Fixed Logstash core compatibility issues with `logstash-input-azure_event_hubs` versions `1.4.8` and earlier https://github.com/elastic/logstash/pull/16485[#16485] +[[known-issues-8-15-3]] +==== Known issues + +* **{ls} can fail to shut down under some circumstances when using pipeline-to-pipeline.** +Check out issue https://github.com/elastic/logstash/issues/16657[#16657] for details. ++ +Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.properties`, which reverts to using v1 of the `PipelineBus` that does not have this issue but may have performance impact in pipeline>pipeline scenarios. + ==== Plugins *Elastic_integration Filter - 0.1.14* @@ -137,6 +150,14 @@ This section summarizes the changes in the following releases: * Fixed a https://github.com/elastic/logstash/issues/16437[regression] from {ls} 8.15.1 in which {ls} removes all quotes from docker env variables, possibly causing {ls} not to start https://github.com/elastic/logstash/pull/16456[#16456] +[[known-issues-8-15-2]] +==== Known issues + +* **{ls} can fail to shut down under some circumstances when using pipeline-to-pipeline.** +Check out issue https://github.com/elastic/logstash/issues/16657[#16657] for details. ++ +Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.properties`, which reverts to using v1 of the `PipelineBus` that does not have this issue but may have performance impact in pipeline>pipeline scenarios. + ==== Plugins *Beats Input - 6.8.4* @@ -172,6 +193,12 @@ If this situation occurs, {ls} may fail to start or some plugins may use a malfo Check out issue https://github.com/elastic/logstash/issues/16437[#16437] for details. + Workaround: Downgrade to {ls} 8.15.0, or temporarily avoid using environment and keystore variable references. +* **{ls} can fail to shut down under some circumstances when using pipeline-to-pipeline.** +Check out issue https://github.com/elastic/logstash/issues/16657[#16657] for details. ++ +Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.properties`, which reverts to using v1 of the `PipelineBus` that does not have this issue but may have performance impact in pipeline>pipeline scenarios. + + [[notable-8.15.1]] ==== Performance improvements and notable issues fixed @@ -206,6 +233,14 @@ Workaround: Downgrade to {ls} 8.15.0, or temporarily avoid using environment and [[logstash-8-15-0]] === Logstash 8.15.0 Release Notes +[[known-issues-8-15-0]] +==== Known issues + +* **{ls} can fail to shut down under some circumstances when using pipeline-to-pipeline.** +Check out issue https://github.com/elastic/logstash/issues/16657[#16657] for details. ++ +Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.properties`, which reverts to using v1 of the `PipelineBus` that does not have this issue but may have performance impact in pipeline>pipeline scenarios. + [[snmp-ga-8.15.0]] ==== Announcing the new {ls} SNMP integration plugin @@ -2579,4 +2614,4 @@ We have added another flag to the Benchmark CLI to allow passing a data file wit This feature allows users to run the Benchmark CLI in a custom test case with a custom config and a custom dataset. https://github.com/elastic/logstash/pull/12437[#12437] ==== Plugin releases -Plugins align with release 7.14.0 \ No newline at end of file +Plugins align with release 7.14.0 From fcd727bbfadb51bb68daba6ee4d956beccb0aabc Mon Sep 17 00:00:00 2001 From: Ry Biesemeyer Date: Fri, 8 Nov 2024 14:25:01 -0800 Subject: [PATCH 2/5] Sync 8.15.4 with others --- docs/static/releasenotes.asciidoc | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/docs/static/releasenotes.asciidoc b/docs/static/releasenotes.asciidoc index c08b17ad08f..2805cc4b74b 100644 --- a/docs/static/releasenotes.asciidoc +++ b/docs/static/releasenotes.asciidoc @@ -72,16 +72,19 @@ This section summarizes the changes in the following releases: [[logstash-8-15-4]] === Logstash 8.15.4 Release Notes +[[known-issues-8-15-4]] +==== Known issues + +* **{ls} can fail to shut down under some circumstances when using pipeline-to-pipeline.** +Check out issue https://github.com/elastic/logstash/issues/16657[#16657] for details. ++ +Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.properties`, which reverts to using v1 of the `PipelineBus` that does not have this issue but may have performance impact in pipeline>pipeline scenarios. + [[notable-8.15.4]] ==== Notable issues fixed * Fixed an issue where Logstash could not consume lines correctly when a codec with a delimiter is in use and the input buffer becomes full https://github.com/elastic/logstash/pull/16482[#16482] -[[known-issues-8-15-4]] -==== Known issues - -* {ls} can fail to shut down in some cases when using pipeline-to-pipeline. This can be avoided by setting `-Dlogstash.pipelinebus.implementation=v1` in `config/jvm.properties`, which reverts to using v1 of the `PipelineBus` that does not have this issue but may have performance impact in pipeline>pipeline scenarios. - [[dependencies-8.15.4]] ==== Updates to dependencies From 34fa54bfec8e23f8593bf42b7bba34a6462a2e75 Mon Sep 17 00:00:00 2001 From: Ry Biesemeyer Date: Mon, 11 Nov 2024 11:10:00 -0800 Subject: [PATCH 3/5] Apply suggestions from code review Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> --- docs/static/releasenotes.asciidoc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/static/releasenotes.asciidoc b/docs/static/releasenotes.asciidoc index 2805cc4b74b..7487f3551dc 100644 --- a/docs/static/releasenotes.asciidoc +++ b/docs/static/releasenotes.asciidoc @@ -237,12 +237,14 @@ Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.proper === Logstash 8.15.0 Release Notes [[known-issues-8-15-0]] -==== Known issues +==== Known issue -* **{ls} can fail to shut down under some circumstances when using pipeline-to-pipeline.** +**{ls} can fail to shut down under some circumstances when you are using <>.** +Check out issue https://github.com/elastic/logstash/issues/16657[#16657] for details. Check out issue https://github.com/elastic/logstash/issues/16657[#16657] for details. + -Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.properties`, which reverts to using v1 of the `PipelineBus` that does not have this issue but may have performance impact in pipeline>pipeline scenarios. +Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.properties`. +This change reverts the `PipelineBus` to `v1`, a version that does not exhibit this issue, but may impact performance in pipeline-to-pipeline scenarios. [[snmp-ga-8.15.0]] ==== Announcing the new {ls} SNMP integration plugin From 4bb9ec427c29cd9f4fc70b775822c0ece10855cb Mon Sep 17 00:00:00 2001 From: Ry Biesemeyer Date: Mon, 11 Nov 2024 12:02:58 -0800 Subject: [PATCH 4/5] Propagate suggestions to other entries --- docs/static/releasenotes.asciidoc | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/docs/static/releasenotes.asciidoc b/docs/static/releasenotes.asciidoc index 7487f3551dc..0f07eaa5d26 100644 --- a/docs/static/releasenotes.asciidoc +++ b/docs/static/releasenotes.asciidoc @@ -73,13 +73,13 @@ This section summarizes the changes in the following releases: === Logstash 8.15.4 Release Notes [[known-issues-8-15-4]] -==== Known issues +==== Known issue -* **{ls} can fail to shut down under some circumstances when using pipeline-to-pipeline.** +**{ls} can fail to shut down under some circumstances when you are using <>.** Check out issue https://github.com/elastic/logstash/issues/16657[#16657] for details. + -Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.properties`, which reverts to using v1 of the `PipelineBus` that does not have this issue but may have performance impact in pipeline>pipeline scenarios. - +Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.properties`. +This change reverts the `PipelineBus` to `v1`, a version that does not exhibit this issue, but may impact performance in pipeline-to-pipeline scenarios. [[notable-8.15.4]] ==== Notable issues fixed @@ -121,13 +121,13 @@ Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.proper * Fixed Logstash core compatibility issues with `logstash-input-azure_event_hubs` versions `1.4.8` and earlier https://github.com/elastic/logstash/pull/16485[#16485] [[known-issues-8-15-3]] -==== Known issues +==== Known issue -* **{ls} can fail to shut down under some circumstances when using pipeline-to-pipeline.** +**{ls} can fail to shut down under some circumstances when you are using <>.** Check out issue https://github.com/elastic/logstash/issues/16657[#16657] for details. + -Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.properties`, which reverts to using v1 of the `PipelineBus` that does not have this issue but may have performance impact in pipeline>pipeline scenarios. - +Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.properties`. +This change reverts the `PipelineBus` to `v1`, a version that does not exhibit this issue, but may impact performance in pipeline-to-pipeline scenarios. ==== Plugins *Elastic_integration Filter - 0.1.14* @@ -154,13 +154,13 @@ Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.proper * Fixed a https://github.com/elastic/logstash/issues/16437[regression] from {ls} 8.15.1 in which {ls} removes all quotes from docker env variables, possibly causing {ls} not to start https://github.com/elastic/logstash/pull/16456[#16456] [[known-issues-8-15-2]] -==== Known issues +==== Known issue -* **{ls} can fail to shut down under some circumstances when using pipeline-to-pipeline.** +**{ls} can fail to shut down under some circumstances when you are using <>.** Check out issue https://github.com/elastic/logstash/issues/16657[#16657] for details. + -Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.properties`, which reverts to using v1 of the `PipelineBus` that does not have this issue but may have performance impact in pipeline>pipeline scenarios. - +Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.properties`. +This change reverts the `PipelineBus` to `v1`, a version that does not exhibit this issue, but may impact performance in pipeline-to-pipeline scenarios. ==== Plugins *Beats Input - 6.8.4* @@ -196,10 +196,12 @@ If this situation occurs, {ls} may fail to start or some plugins may use a malfo Check out issue https://github.com/elastic/logstash/issues/16437[#16437] for details. + Workaround: Downgrade to {ls} 8.15.0, or temporarily avoid using environment and keystore variable references. -* **{ls} can fail to shut down under some circumstances when using pipeline-to-pipeline.** +* **{ls} can fail to shut down under some circumstances when you are using <>.** Check out issue https://github.com/elastic/logstash/issues/16657[#16657] for details. + -Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.properties`, which reverts to using v1 of the `PipelineBus` that does not have this issue but may have performance impact in pipeline>pipeline scenarios. +Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.properties`. +This change reverts the `PipelineBus` to `v1`, a version that does not exhibit this issue, but may impact performance in pipeline-to-pipeline scenarios. + @@ -241,7 +243,6 @@ Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.proper **{ls} can fail to shut down under some circumstances when you are using <>.** Check out issue https://github.com/elastic/logstash/issues/16657[#16657] for details. -Check out issue https://github.com/elastic/logstash/issues/16657[#16657] for details. + Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.properties`. This change reverts the `PipelineBus` to `v1`, a version that does not exhibit this issue, but may impact performance in pipeline-to-pipeline scenarios. From d07acbb080e6fe179579a1f25ec568a28f5df5b1 Mon Sep 17 00:00:00 2001 From: Ry Biesemeyer Date: Mon, 11 Nov 2024 13:02:40 -0800 Subject: [PATCH 5/5] Apply suggestions from code review formatting: - plus-to-continue only in lists, - consistency of linebreaks before next section Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> --- docs/static/releasenotes.asciidoc | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/docs/static/releasenotes.asciidoc b/docs/static/releasenotes.asciidoc index 0f07eaa5d26..8381434fba1 100644 --- a/docs/static/releasenotes.asciidoc +++ b/docs/static/releasenotes.asciidoc @@ -77,9 +77,9 @@ This section summarizes the changes in the following releases: **{ls} can fail to shut down under some circumstances when you are using <>.** Check out issue https://github.com/elastic/logstash/issues/16657[#16657] for details. -+ Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.properties`. This change reverts the `PipelineBus` to `v1`, a version that does not exhibit this issue, but may impact performance in pipeline-to-pipeline scenarios. + [[notable-8.15.4]] ==== Notable issues fixed @@ -125,9 +125,9 @@ This change reverts the `PipelineBus` to `v1`, a version that does not exhibit t **{ls} can fail to shut down under some circumstances when you are using <>.** Check out issue https://github.com/elastic/logstash/issues/16657[#16657] for details. -+ Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.properties`. This change reverts the `PipelineBus` to `v1`, a version that does not exhibit this issue, but may impact performance in pipeline-to-pipeline scenarios. + ==== Plugins *Elastic_integration Filter - 0.1.14* @@ -158,9 +158,9 @@ This change reverts the `PipelineBus` to `v1`, a version that does not exhibit t **{ls} can fail to shut down under some circumstances when you are using <>.** Check out issue https://github.com/elastic/logstash/issues/16657[#16657] for details. -+ Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.properties`. This change reverts the `PipelineBus` to `v1`, a version that does not exhibit this issue, but may impact performance in pipeline-to-pipeline scenarios. + ==== Plugins *Beats Input - 6.8.4* @@ -203,8 +203,6 @@ Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.proper This change reverts the `PipelineBus` to `v1`, a version that does not exhibit this issue, but may impact performance in pipeline-to-pipeline scenarios. - - [[notable-8.15.1]] ==== Performance improvements and notable issues fixed @@ -243,7 +241,6 @@ This change reverts the `PipelineBus` to `v1`, a version that does not exhibit t **{ls} can fail to shut down under some circumstances when you are using <>.** Check out issue https://github.com/elastic/logstash/issues/16657[#16657] for details. -+ Workaround: Add `-Dlogstash.pipelinebus.implementation=v1` to `config/jvm.properties`. This change reverts the `PipelineBus` to `v1`, a version that does not exhibit this issue, but may impact performance in pipeline-to-pipeline scenarios.