From 19de914fbba414892effedf7212bd3cd94532960 Mon Sep 17 00:00:00 2001 From: andsel Date: Thu, 14 Nov 2024 11:35:33 +0100 Subject: [PATCH 1/4] Updates release notes for 8.14.x to call for an update to a subsequent minor for fix performance regression in JSON decoding. --- docs/static/releasenotes.asciidoc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/static/releasenotes.asciidoc b/docs/static/releasenotes.asciidoc index b067372e108..e393db92e22 100644 --- a/docs/static/releasenotes.asciidoc +++ b/docs/static/releasenotes.asciidoc @@ -66,6 +66,8 @@ This section summarizes the changes in the following releases: [[logstash-8-14-3]] === Logstash 8.14.3 Release Notes +IMPORTANT: Update to Logstash version 8.15 or later because with the JSON serialization fix for payloads that are not UTF-8 (https://github.com/elastic/logstash/pull/16168[#16168]) +a performance regression was introduced that was fixed with https://github.com/elastic/logstash/pull/16313[#16313]. [[notable-8.14.3]] ==== Enhancements and notable issues fixed From 2a61b87a098dbfd14adca532539eb7990e09c4b6 Mon Sep 17 00:00:00 2001 From: andsel Date: Thu, 14 Nov 2024 14:01:05 +0100 Subject: [PATCH 2/4] Used common format for this kind of messages. --- docs/static/releasenotes.asciidoc | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/docs/static/releasenotes.asciidoc b/docs/static/releasenotes.asciidoc index e393db92e22..6452caadef9 100644 --- a/docs/static/releasenotes.asciidoc +++ b/docs/static/releasenotes.asciidoc @@ -66,8 +66,15 @@ This section summarizes the changes in the following releases: [[logstash-8-14-3]] === Logstash 8.14.3 Release Notes -IMPORTANT: Update to Logstash version 8.15 or later because with the JSON serialization fix for payloads that are not UTF-8 (https://github.com/elastic/logstash/pull/16168[#16168]) -a performance regression was introduced that was fixed with https://github.com/elastic/logstash/pull/16313[#16313]. + +[[known-issues-8-14-3]] +==== Known issue + +**{ls} in serializing non UTF-8 JSON payloads suffer of performance regression.** +Starting from version `8.14.1` was introduced a fix in handling JSON contained in non UTF-8 strings https://github.com/elastic/logstash/issues/15833[#15833]. +This fix introduced a performance regression that was solved with https://github.com/elastic/logstash/pull/16313[#16313] and +released starting with version `8.15.0`. +Workaround: update {ls} installation to `8.15.0` or later minor. [[notable-8.14.3]] ==== Enhancements and notable issues fixed From 276f10b773a6321225005dbba52770e71a891938 Mon Sep 17 00:00:00 2001 From: Andrea Selva Date: Thu, 14 Nov 2024 16:29:25 +0100 Subject: [PATCH 3/4] Better wording in changelog MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: João Duarte --- docs/static/releasenotes.asciidoc | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/docs/static/releasenotes.asciidoc b/docs/static/releasenotes.asciidoc index 6452caadef9..b4a9c6f4f67 100644 --- a/docs/static/releasenotes.asciidoc +++ b/docs/static/releasenotes.asciidoc @@ -70,11 +70,10 @@ This section summarizes the changes in the following releases: [[known-issues-8-14-3]] ==== Known issue -**{ls} in serializing non UTF-8 JSON payloads suffer of performance regression.** -Starting from version `8.14.1` was introduced a fix in handling JSON contained in non UTF-8 strings https://github.com/elastic/logstash/issues/15833[#15833]. -This fix introduced a performance regression that was solved with https://github.com/elastic/logstash/pull/16313[#16313] and -released starting with version `8.15.0`. -Workaround: update {ls} installation to `8.15.0` or later minor. +**{ls} performance regression in JSON encoding** +{ls} `8.14.1` fixed JSON encoding of strings contaning non-unicode data https://github.com/elastic/logstash/issues/15833[#15833]. +The fix introduced a performance regression that has since been solved with https://github.com/elastic/logstash/pull/16313[#16313] and included in {ls} `8.15.0`. +There is no workaround for this issue, please upgrade to {ls} 8.15.0 or later. [[notable-8.14.3]] ==== Enhancements and notable issues fixed From d2895eb86f4763e9155e2e7f90cf1a6ca0666233 Mon Sep 17 00:00:00 2001 From: Andrea Selva Date: Thu, 14 Nov 2024 18:06:05 +0100 Subject: [PATCH 4/4] Fixed typo MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: João Duarte --- docs/static/releasenotes.asciidoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/static/releasenotes.asciidoc b/docs/static/releasenotes.asciidoc index b4a9c6f4f67..df29250d7de 100644 --- a/docs/static/releasenotes.asciidoc +++ b/docs/static/releasenotes.asciidoc @@ -71,7 +71,7 @@ This section summarizes the changes in the following releases: ==== Known issue **{ls} performance regression in JSON encoding** -{ls} `8.14.1` fixed JSON encoding of strings contaning non-unicode data https://github.com/elastic/logstash/issues/15833[#15833]. +{ls} `8.14.1` fixed a bug in the JSON encoding of strings containing non-unicode data https://github.com/elastic/logstash/issues/15833[#15833]. The fix introduced a performance regression that has since been solved with https://github.com/elastic/logstash/pull/16313[#16313] and included in {ls} `8.15.0`. There is no workaround for this issue, please upgrade to {ls} 8.15.0 or later.