-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jan 28] Adds new runscript Crowdstrike response action #6435
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @natasha-moore-elastic, this looks awesome ❤️
Leaving some thoughts here:
- Runscript response action - currently it is on the list of all response actions, however it's the first response action that is not supported by Endpoint, but only on CrowdStrike - should we distinguish this somehow, or at least mention 'CrowdStrike only' or something like that ?
- In SentinelOne, we have a information about:
View past response action activity in the [response actions history](https://security-docs_bk_6435.docs-preview.app.elstc.co/guide/en/serverless/main/security-response-actions-history.html) log.
We are capable of doing this for CrowdStrike too, so we could think of adding it to the docs too, what do you think? - runscript examples - can we add 3 examples ? 1 per each argument : Raw, HostPath, CloudFile ?
- I was wrong when confirming the predefined roles for RunScript. They should not be the same as for Isolate, but the same as for Execute - meaning:
Predefined role: SOC manager or Endpoint operations analyst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes 👍 I left one minor thing, otherwise LGTM :) This is fantastic ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
* Adds new runscript Crowdstrike response action * Add missing information * Updates example * Address feedback * Update example (cherry picked from commit 4a52fe9) # Conflicts: # docs/serverless/endpoint-response-actions/response-actions.asciidoc # docs/serverless/endpoint-response-actions/third-party-actions.asciidoc
#6435) (#6490) * [Jan 28] Adds new runscript Crowdstrike response action (#6435) * Adds new runscript Crowdstrike response action * Add missing information * Updates example * Address feedback * Update example (cherry picked from commit 4a52fe9) # Conflicts: # docs/serverless/endpoint-response-actions/response-actions.asciidoc # docs/serverless/endpoint-response-actions/third-party-actions.asciidoc * Delete docs/serverless directory and its contents --------- Co-authored-by: natasha-moore-elastic <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Resolves #6365.
Previews
ESS:
Serverless: