-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using nsis and nsis-web uploads latest.yml twice #8794
Comments
So I took a look at the code, and I don't think it was ever expected to have both The auto-update docs state only The problem with your suggestion is that it'll break auto-update for
TLDR; AFAICT, I can't change the behavior to support both deployments w/ both auto-updates. It wasn't designed to. |
Version:
25.1.8
Target:
build --win --x64 --ia32 -p always
Will publish bot
nsis
andnsis-web
installers/update files.However it will also upload the
latest.yml
twice fornsis
andnsis-web
.And there is a race condition and I have noted that the one that wins is random and overwrites the first.
Update will work either way but will download more data if
nsis
wins to upload itslatest.yml
since it contains the --x64 --ia32 architectures.Maybe a good solution would be to only upload latest.yml for
nsis-web
in these cases?Or at least add a config option to disable the upload of
latest.yml
pertarget
sonsis
latest.yml
can be ignored?The text was updated successfully, but these errors were encountered: