-
Notifications
You must be signed in to change notification settings - Fork 240
Splitting into version branches #1674
Comments
👋 Thanks for opening your first issue here! |
Going to be working on this. Hopefully I'll have a PR soon-ish |
I've been looking at our crowdin implementation and it looks like we are not using the GitHub integration and just the GitHub action. Adding the GitHub integration will make the handling of version branches easier. I'm trying to come up with a plan that I'll update as I found more info.
@erickzhao how does this sound? Who else should I ping to validate this (at least the high level vision)? |
Maybe @vhashimotoo, some folks say that he has an understanding of i18n workflow. But I not sure if he would talk 🙃 |
Last time I read him, he wanted some quiet time and did not want to be pinged so I wanted to be respectful of his whishes. That said, if you have a way to communicate with him and see if he would like to validate the above strategy it would be awesome 😉 |
@molant for some issues I have exceptions. From opening this issue I always think it's an out-of-scope because it's easy to say to do, but in the practice, I not understanding how does this should work, to create the best DX for everyone. Who is the Source of Truth for scripts?The question itself is who runs the scripts, which branch? If we talk about every branch runs the script itself, who should update these scripts? In my best vision, it's greatest to split the branches, clean them, and runs scripts from the This gives a guarantee of the script is be always on top of the tree. Not End But And Not ContinueI still have many other minds about this in the head, and maybe will share them when having more details. But this is only one of the big problems which I can see. The plan itself maybe looks good, but yes it's only the tip of the iceberg and can have many other issues. |
Thanks @vhashimotoo |
Since all issues which I found can be fixed or they go to only a single source, yes it's possible and I already have a dirty solution (which means this isn't tested, but it's should work) |
Currently, translation contents are stored in versions folders. But doing this occurs some confusing on Crowdin because there are many contents like these:
According Crowdin docs, I think it needs to split them into their version branches:
The text was updated successfully, but these errors were encountered: