Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerbuild provides insufficient node version for pacote@^21.0.0 #2079

Closed
ClFeSc opened this issue Jan 16, 2025 · 0 comments · Fixed by #2096
Closed

Dockerbuild provides insufficient node version for pacote@^21.0.0 #2079

ClFeSc opened this issue Jan 16, 2025 · 0 comments · Fixed by #2096
Assignees
Labels

Comments

@ClFeSc
Copy link

ClFeSc commented Jan 16, 2025

Steps to reproduce

Running the steps to build using docker from the Readme (https://github.com/element-hq/element-desktop?tab=readme-ov-file#docker) does not successfully build the element desktop package.

  1. Clone the repo (git clone https://github.com/element-hq/element-desktop.git && cd cd element-desktop)
  2. Run yarn install as specified in https://github.com/element-hq/element-desktop?tab=readme-ov-file#first-steps.
  3. Run yarn run fetch --noverify --cfgdir "" as specified in https://github.com/element-hq/element-desktop?tab=readme-ov-file#fetching-element.
  4. Run yarn run docker:setup as specified in https://github.com/element-hq/element-desktop?tab=readme-ov-file#docker.
  5. Run yarn run docker:install as specified in https://github.com/element-hq/element-desktop?tab=readme-ov-file#docker.

Outcome

What did you expect?

Successful installation of node modules inside the build container.

What happened instead?

error [email protected]: The engine "node" is incompatible with this module. Expected version "^20.17.0 || >=22.9.0". Got "20.15.1"

This seems to stem from the update to pacote version 21.0.0 in #2017. Since version 21.0.0 pacote is only compatible with node versions ^20.17.0 || >=22.9.0 as specified in the Breaking Changes sections of the release notes in their repository: https://github.com/npm/pacote/releases/tag/v21.0.0

As far as I can tell, changing the node version in https://github.com/element-hq/element-desktop/blob/develop/dockerbuild/Dockerfile#L24 from 20.15.1 to 20.17.0 resolves this issue. I have not checked for other problems this newer version might create, though.

Operating system

No response

Application version

No response

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants