Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintainance of pic8259_simple crate #5

Open
phil-opp opened this issue Jul 26, 2018 · 4 comments
Open

Maintainance of pic8259_simple crate #5

phil-opp opened this issue Jul 26, 2018 · 4 comments

Comments

@phil-opp
Copy link
Contributor

Hi @emk! I plan to finally write a post about hardware interrupts for https://os.phil-opp.com/. Your pic8259_simple crate would be very useful for this. Thanks for writing it!

One concern I have is that this might prompt people to file issues or submit pull requests, so I wanted to ask whether you're still interested in maintaining this crate. If yes, awesome! If not, we could maintain it under the rust-osdev organization if you like (only the pic crate, not toyos). Or we could fork it and publish it under a new name, if you prefer.

Thanks again!

@emk
Copy link
Owner

emk commented Jul 28, 2018

I loved your OS series and it was a huge inspiration to me!

I'm definitely happy to accept PRs, though I'm in the middle of moving to a new house for the next few weeks, so turnaround might be a bit spotty until late August.

I'd also be willing to share maintenance of this crate under the the rust-osdev organization, provided I still keep commit access. :-) That way you could make new releases whenever you wanted.

Note that pic8259_simple also relies on cpuio, a very simple and (I hope) clean interface to outb and friends. This can also move to rust-osdev if that makes sense for you.

Basically, I'm happy to do anything I can do to make these crates more usable for your readers! If you have API feedback, etc., we can definitely change things.

@phil-opp
Copy link
Contributor Author

I loved your OS series and it was a huge inspiration to me!

Thank you so much, really great to hear that!

I'm definitely happy to accept PRs, though I'm in the middle of moving to a new house for the next few weeks, so turnaround might be a bit spotty until late August.

Ok cool! Then I would say let's keep things the way they are for now. I'm quite happy with the API and documentation, so I think I will just use the current crates.io version.

I sent you an invitation to rust-osdev, so you can always share this crate if you become overwhelmed with maintainance. You would of course keep admin access.

Note that pic8259_simple also relies on cpuio, a very simple and (I hope) clean interface to outb and friends. This can also move to rust-osdev if that makes sense for you.

We also have a simple port interface as part of the x86_64 crate. Seems like cpuio is a bit more featureful (Port vs UnsafePort), but I only took a quick look. I'll definitely keep it in mind, maybe it makes sense to use it in x86_64.

Basically, I'm happy to do anything I can do to make these crates more usable for your readers! If you have API feedback, etc., we can definitely change things.

Thanks so much for your help! I'm quite happy with the current API and I think your crate will be very useful for my readers. Thanks again for creating it!

@phil-opp
Copy link
Contributor Author

Hi @emk, are you still willing to maintain this crate? I saw that you didn't reply in #7 for the last months, so I thought I'd ask again. I'd be happy to move this crate to the rust-osdev organization if you like some help in maintainence. If you prefer, we could also create a fork of it if you prefer.

@phil-opp phil-opp reopened this Feb 11, 2021
@phil-opp
Copy link
Contributor Author

As noted in #7 (comment), I created a fork of the pic8259 crate under the rust-osdev organization: https://github.com/rust-osdev/pic8259. The forked crate is avaliable on crates.io as pic8259 v0.10.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants