-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
file.includes is not a function #159
Comments
Having same issue when using a block that uses embed multiple times |
I didn't notice it as much on a newer project I worked on, which made me wonder if they slipped in a fix in one of the Twig.js releases. But if they haven't and you still experience the issue, the workaround we were using basically just moves to using From:
To:
|
@evanmwillhite okay I just realized namespaces is not the culprit but rather including templates with embed. I see your modifications 2bcf6dd to get it working. I'll see if I can change our templates as they are pretty complex. |
This PR fixes this issue for me: twigjs/twig.js#784 |
emulsify-drupal:^2.0
node version: v14.8.0
yarn version: v1.22.4
What you did:
Manually upgrade emulsify-drupal from ^1.0@beta to ^2.0
What happened:
Experiencing errors with
file.includes is not a function
Problem description:
Hi @evanmwillhite, I found your ticket twigjs/twig.js#682 about nested includes and was wondering if you found a solution already. I was able to fix by removing namespaces in one of my components. I tried reverting twigjs from v1.15.2 to v.1.13.3 but that seemed to cause other problems.
I noticed in this repo's components, the article page include a grid organism, which include a heading atom so it doesn't seem like you're running into this issue anymore.
┆Issue is synchronized with this Jira Story by Unito
The text was updated successfully, but these errors were encountered: