Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smidge can't find files #69

Closed
AaronSadlerUK opened this issue Oct 14, 2021 · 4 comments
Closed

Smidge can't find files #69

AaronSadlerUK opened this issue Oct 14, 2021 · 4 comments

Comments

@AaronSadlerUK
Copy link

AaronSadlerUK commented Oct 14, 2021

When running an Umbraco v9 site which has been published, and the app plugins folder manually (due to #68) added to the publish folder.

Smidge throws an error saying it cannot find the js files, even though they can be browsed to directly.

My first thought is whether it's failing to minify the file and so throwing an error, I'm not sure though

@enkelmedia
Copy link
Owner

Hmm.

Are you on the latest version? Where this issue should be fixed #64

@AaronSadlerUK
Copy link
Author

I'm running on 9.0.0-rc003, the files get copied in development fine, it's when you publish using Visual Studio (or dot net publish) when they don't get copied to the output folder

@AaronSadlerUK
Copy link
Author

Ok so the current rc on NuGet causes the issue, renaming the app_plugins to App_Plugins in the manifest fixes the issue.

It looks like this fix from #64 (comment) is the fix, it just needs pushing to nuget

@enkelmedia
Copy link
Owner

Hi!

Sorry! I must have been tiered last time I worked on the package, I was waiting to include the PR in the release #62

But I've gone a head and pusha rc4-release that is now on NuGet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants