You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ACC is encountering a wave of spam with epically long username requests, and that's causing a few odd UI issues.
Right now, requests are dropped twice by our spam filters. This lists them twice in the the "Last 5 Closed requests" section on the main page. Once a request is dropped by a spam filter, that should stop all other actions, as a drop is a dead-end state without user intervention.
Detail Page: Logs are oddly compressed on the details and times, forcing some funky scrolling.
Other requests from the same emails and IP overlap, and force the page to have a horizontal scroll
The "Requested Name" overlaps the "Log" heading on the detail page. If anything, this is the place where we need the full username shown, but perhaps we can wrap it if it's long?
Copying a quote from FL4 from #903 so it doesn't get lost...
Testing-wise, though, I noticed a potential gap in this solution in that with the "Drop" ban action, we still send a confirmation email to the requester. This is intentional in order to give the requester as little information as possible that they have been banned, but it means that it's still possible for the requester to mark their request as email confirmed, thus bypassing the change made in this PR. Indeed, about 21% of the requests behind #900 were email confirmed and would thus not be excluded from "last closed" by this change.
It's completely fair to say that it's out-of-scope for this PR and something to be fixed in a follow-up PR, by the way; there are a couple ways the gap could be fixed. Again, I'm more making sure that you're aware of this.
ACC is encountering a wave of spam with epically long username requests, and that's causing a few odd UI issues.
Example request: #340704
The text was updated successfully, but these errors were encountered: