Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super long username issues #900

Open
Matthewrbowker opened this issue Jan 27, 2024 · 1 comment
Open

Super long username issues #900

Matthewrbowker opened this issue Jan 27, 2024 · 1 comment

Comments

@Matthewrbowker
Copy link
Member

ACC is encountering a wave of spam with epically long username requests, and that's causing a few odd UI issues.

  1. Right now, requests are dropped twice by our spam filters. This lists them twice in the the "Last 5 Closed requests" section on the main page. Once a request is dropped by a spam filter, that should stop all other actions, as a drop is a dead-end state without user intervention.
  2. Detail Page: Logs are oddly compressed on the details and times, forcing some funky scrolling.
  3. Other requests from the same emails and IP overlap, and force the page to have a horizontal scroll
  4. The "Requested Name" overlaps the "Log" heading on the detail page. If anything, this is the place where we need the full username shown, but perhaps we can wrap it if it's long?

Example request: #340704

@Matthewrbowker
Copy link
Member Author

Copying a quote from FL4 from #903 so it doesn't get lost...

Testing-wise, though, I noticed a potential gap in this solution in that with the "Drop" ban action, we still send a confirmation email to the requester. This is intentional in order to give the requester as little information as possible that they have been banned, but it means that it's still possible for the requester to mark their request as email confirmed, thus bypassing the change made in this PR. Indeed, about 21% of the requests behind #900 were email confirmed and would thus not be excluded from "last closed" by this change.

It's completely fair to say that it's out-of-scope for this PR and something to be fixed in a follow-up PR, by the way; there are a couple ways the gap could be fixed. Again, I'm more making sure that you're aware of this.

@stwalkerster stwalkerster moved this to Incoming in Bugs May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Incoming
Development

No branches or pull requests

2 participants
@Matthewrbowker and others