From 4c1806c5871b226e885ab2474c57d629a8e5982c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.rolim@lnls.br>
Date: Fri, 22 Nov 2024 12:11:34 -0300
Subject: [PATCH 1/2] ioc: improve group processing warning messages.

Missing newlines and quotes made it hard to parse warning messages.
---
 ioc/groupprocessorcontext.cpp | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/ioc/groupprocessorcontext.cpp b/ioc/groupprocessorcontext.cpp
index 07f18b3d2..60882846d 100644
--- a/ioc/groupprocessorcontext.cpp
+++ b/ioc/groupprocessorcontext.cpp
@@ -33,8 +33,7 @@ void GroupProcessorContext::assign(const Value& value) {
             groupPvConfig.structureId = value.as<std::string>();
 
         } else {
-            groupConfigProcessor->groupProcessingWarnings += "Unknown group option ";
-            groupConfigProcessor->groupProcessingWarnings += field;
+            groupConfigProcessor->groupProcessingWarnings += SB()<<"Unknown group option: \""<<field<<"\"\n";
         }
         field.clear();
 
@@ -59,7 +58,7 @@ void GroupProcessorContext::assign(const Value& value) {
             } else if(tname == "const") {
                 type = MappingInfo::Const;
             } else {
-                groupConfigProcessor->groupProcessingWarnings += SB()<<"Unknown mapping +type:\""<<tname<<"\" ignored";
+                groupConfigProcessor->groupProcessingWarnings += SB()<<"Unknown mapping +type:\""<<tname<<"\" ignored\n";
             }
             groupField.info.type = type;
 
@@ -82,8 +81,7 @@ void GroupProcessorContext::assign(const Value& value) {
             groupField.info.cval = value;
 
         } else {
-            groupConfigProcessor->groupProcessingWarnings += "Unknown group field option ";
-            groupConfigProcessor->groupProcessingWarnings += field + ":" + key;
+            groupConfigProcessor->groupProcessingWarnings += SB()<<"Unknown group field option: \""<<field<<":"<<key<<"\"\n";
         }
         key.clear();
     }

From fcd9e30e41d465f6a74d6eed9cf1defbd635eac8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.rolim@lnls.br>
Date: Tue, 10 Dec 2024 13:08:54 -0300
Subject: [PATCH 2/2] ioc: fix typo in warning message.

---
 ioc/groupconfigprocessor.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ioc/groupconfigprocessor.cpp b/ioc/groupconfigprocessor.cpp
index ff814124a..9f5e39440 100644
--- a/ioc/groupconfigprocessor.cpp
+++ b/ioc/groupconfigprocessor.cpp
@@ -225,7 +225,7 @@ void GroupConfigProcessor::defineFields(GroupDefinition& groupDefinition, const
         }
 
         if(fieldName.empty() && fieldConfig.info.type!=MappingInfo::Meta) {
-            fprintf(stderr, "%s.%s Error: only +type:\"meta\" map be mapped at struct top\n",
+            fprintf(stderr, "%s.%s Error: only +type:\"meta\" can be mapped at struct top\n",
                     groupName.c_str(), fieldName.c_str());
             continue;
         }