Coinbase deprecated some endpoints, breaking the CB plugin

[eprbell]

On Nov 30 2023 Coinbase deprecated the Buys and Sells endpoints in the v2 API: https://docs.cloud.coinbase.com/sign-in-with-coinbase/docs/api-buys

These endpoints were used by the DaLI Coinbase plugin: their deprecation broke it. Now when running the plugin the following error occurs:
Error <Response [410]>: This API has been deprecated. Please use the Transactions API (https://docs.cloud.coinbase.com/sign-in-with-coinbase/docs/api-transactions#list-transactions) to view your past transactions.

The Buys and Sells endpoints were used by the plugin to get fee information for fill transactions. At first glance it doesn't seem the list-transactions endpoint (mentioned in the error message) returns fee information, but more investigation is needed.

If fee information is not available from list-transactions we may need to:

• migrate the plugin to the v3 REST API (which implies rewriting a good part of the plugin), or
• reimplement the plugin as a AbstractCcxtInputPlugin subclass (also a rewrite but at least it would inherit a lot of functionality from the superclasses).

[ndopencode]

Coinbase has further deprecated fields within the list/show transactions endpoints on 2024-02-07 such as the _DETAILS: str = "details" field. See for further information: https://docs.cloud.coinbase.com/sign-in-with-coinbase/docs/api-transactions#parameters

[imbobbb]

first time user here. awesome project btw. @eprbell in terms of fee information, adding the new_version_opt_in=true parameter seems to fetch fee information. so "/v2/accounts/{account_id}/transactions?new_version_opt_in=true" should work. I tried to make changes, but as @ndopencode mentioned, coinbase has deprecated other fields too and I don't have a lot of transactions to test every transaction type.

[eprbell]

first time user here. awesome project btw. @eprbell in terms of fee information, adding the new_version_opt_in=true parameter seems to fetch fee information. so "/v2/accounts/{account_id}/transactions?new_version_opt_in=true" should work. I tried to make changes, but as @ndopencode mentioned, coinbase has deprecated other fields too and I don't have a lot of transactions to test every transaction type.

Interesting info: thanks for sharing it! Unfortunately right now I don't have a lot of time to look into it, but if anybody else wants to submit a PR I'll happily review the code.

[rapus95]

I wonder if the endpoint described in https://docs.cdp.coinbase.com/exchange/reference/exchangerestapi_postreports might offer a hassle-free implementation by just kicking off a csv-report-generation for all required data and telling the user to rerun the script later, which then checks for the ready state. And if it's ready, the endpoints will provide csv files to be downloaded and parsed. My expectation would be that it might be less cumbersome to reorganize multiple csv's rather than juggling multiple api endpoints.

Edit: in particular, since the code for reorganization of the csv could also be used to parse manually downloaded csv's.

Edit2: They now also have an official python sdk: https://github.com/coinbase/coinbase-advanced-py

[eprbell]

Thanks for the links: I'll take a look.