You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When chained with the SmartHTML we get some kind of double-encoding and end up with symbols rendered as &x1234; in a browser. What is the purpose of the encode_entities_numeric - some sanitizing similar to the regex in SmartHML above? If that's the case and if is_valid is always followed by the SmartHTML then encode_entities_numeric could probably be just removed. But I'm no expert in perl and DocDB and need advice on it.
Also is_valid is probably a confusing name as it doesn't really check that something is valid, but it seems to modify things instead.
The text was updated successfully, but these errors were encountered:
If I get it right, this line in
SmartHTML
is supposed to escape html special characters:DocDB/DocDB/cgi/HTMLUtilities.pm
Lines 33 to 34 in 4e5b406
But it messes up non-ASCII symbols in utf8, like "é". Consider using some other utf8-friendly way for that, for instance:
Things get more complicated with this code:
DocDB/DocDB/cgi/UntaintHTML.pm
Lines 32 to 36 in 4e5b406
When chained with the
SmartHTML
we get some kind of double-encoding and end up with symbols rendered as&x1234;
in a browser. What is the purpose of theencode_entities_numeric
- some sanitizing similar to the regex inSmartHML
above? If that's the case and ifis_valid
is always followed by theSmartHTML
thenencode_entities_numeric
could probably be just removed. But I'm no expert in perl and DocDB and need advice on it.Also
is_valid
is probably a confusing name as it doesn't really check that something is valid, but it seems to modify things instead.The text was updated successfully, but these errors were encountered: