Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slides Jumping Around #69

Open
lionssharedigital opened this issue Feb 4, 2021 · 4 comments
Open

Slides Jumping Around #69

lionssharedigital opened this issue Feb 4, 2021 · 4 comments

Comments

@lionssharedigital
Copy link

Hi,

Thank you for your help.
Live Site: https://www.the1thing.com/
Staging: http://the1thingstage.wpengine.com/

I think the library may be out of date but I don't have the system to compile the JS at this point. I will work on this but wanted to see if you have seen this issue before:

One this page: https://www.the1thing.com/shop/the-one-thing/
Staging site: https://the1thingstage.wpengine.com/shop/the-one-thing/

Problem:
When you click the "Look Inside", it brings up a gallrey of images. When you click next or prev, the slides jump around. It looks like they are out of order. Once you've cycled around it, then it starts to work reliably. We are using the latest version of Jquery.
Here's a Loom showing the issue: https://www.loom.com/share/b2fd9654802f4f7c9ddef477a7469219

Desiered Result:
I'd like for the slider to just show the next or previous image in the correct order.

I've tried turning off plugins and Jquery migrate.

Thank you again for any help or guidance,
Jesse

/////
Before anything else, make sure to updatethe1 SudoSlider and jQuery to the latest version. Otherwise, I will fart in your general direction, and maybe close the issue.

If your issue is an error report, make sure to include the following, or your issue will be ignored and/or closed

  • A clear description of what happens.
  • A clear description of what is supposed to happen.
  • One of the following:
    • A link to a page where the issue is present (Like JSFiddle or similar).
    • A .zip file containing a page where the issue is present.

Yes, you really need to share a page, way to often the issues are due to some dependency, so you will be ignored if you don't.

@erik-krogh
Copy link
Owner

I did actually just update some of the code that is relevant to your issue (See #67).
So an update might just fix it.

But I'll take a look.

@erik-krogh
Copy link
Owner

Updating to the latest version fixes it.
I downloaded a local copy of your page, and manually updated the version of SudoSlider you had bundled.
That fixed the issue.

@lionssharedigital
Copy link
Author

lionssharedigital commented Feb 5, 2021 via email

@erik-krogh
Copy link
Owner

Here is the manually updated main.js: https://gist.github.com/erik-krogh/e444ddd3d58315e0787cc9311c0ceb26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants