Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size Error #5

Open
hartherbert opened this issue Feb 7, 2017 · 2 comments
Open

Size Error #5

hartherbert opened this issue Feb 7, 2017 · 2 comments

Comments

@hartherbert
Copy link

Using your plugin I noticed there is a error with the preview-size.

See the following image.

screenshot_20170207-112750

This screenshot was taken with my Samsung Galaxy S6 Edge. On my Samsung Galaxy Alpha it works fine.

  • Samsung Galaxy S6 Edge Display Resolution 2560 x 1440 Pixel (576 PPI)
  • Samsung Galaxy Alpha Display Resolution 1280 x 720 Pixel (312 PPI)

I could not find the error in your code, so that's why I am asking you to add the feature to support larger image sizes.

the plugin from techieyann displays the preview-size right on my S6 Edge.

Thanks

@erperejildo
Copy link
Owner

Interesting...

We merged this branch to the original one so this one should have the same issue. Can you publish this issue there? (add just a reference but publish further comments on it).
https://github.com/cordova-plugin-camera-preview/cordova-plugin-camera-preview/issues
This repo is no longer under maintenance.

I'll have a look to techieyann one and I'll create a PR ASAP (to the original one)

@hartherbert
Copy link
Author

hartherbert commented Feb 7, 2017

Ok I'll publish an issue there

To track the issue

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants