Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐕 Batch: Add versioning in Docker builds #1069

Closed
DhanshreeA opened this issue Mar 13, 2024 · 7 comments · Fixed by #1481
Closed

🐕 Batch: Add versioning in Docker builds #1069

DhanshreeA opened this issue Mar 13, 2024 · 7 comments · Fixed by #1481
Assignees
Labels
enhancement New feature or request

Comments

@DhanshreeA
Copy link
Member

DhanshreeA commented Mar 13, 2024

Summary

Right now all our Docker images are tagged "latest" by default. This is quite problematic, since we cannot roll back to a version we knew worked (especially since we don't have tests for the builds themselves). Another reason why this would have been nice to have is for sake of comparison around size differences between older builds and the new slimmer builds. I reckon this would not be entirely easy to implement since the ersilia cli isn't tag aware and always pulls the latest tag.

Objectives

###Documentation

@DhanshreeA DhanshreeA added the bug Something isn't working label Mar 13, 2024
@miquelduranfrigola
Copy link
Member

miquelduranfrigola commented Mar 18, 2024

We decided:

  1. Versioning Ersilia base image (and other images created with the corresponding GitHub Action in the ersilia CLI repo). Version should be in synch with the actual ersilia version. The latest tag should continue to exist.
  2. Models will be versioned with a timestamp (e.g. 2024.03.18).
  3. The version of the ersilia base image used for building the model will be implicit and can be queried at model building time. Importantly, the FROM ersiliaos/ersilia:latest used at model building time should be replaced to use the exact version of the ersilia base image. This should be done dynamically in the GitHub Action.
  4. We should add a flag to the ersilia fetch command (e.g. --version 2024.03.18) in case users want to use an older version of the model.

@DhanshreeA DhanshreeA changed the title 🐛 Bug: Improve versioning in Docker builds [🐕 Batch]: Improve versioning in Docker builds May 28, 2024
@DhanshreeA DhanshreeA moved this to Queue in Ersilia Model Hub May 28, 2024
@GemmaTuron
Copy link
Member

Hi @DhanshreeA

Have the decisions set above been converted to actual tasks? Is this a Batch or an Epic, and are there other issues open related to this?

@DhanshreeA
Copy link
Member Author

@GemmaTuron the discussion above has not been converted to tasks, and I would qualify this as a batch since it would take a non trivial amount of effort to complete this, however not as intense as an epic/sprint.

@GemmaTuron GemmaTuron changed the title [🐕 Batch]: Improve versioning in Docker builds 🐕 Batch: Improve versioning in Docker builds Sep 24, 2024
@GemmaTuron GemmaTuron moved this to On Hold in Ersilia Model Hub Sep 24, 2024
@GemmaTuron
Copy link
Member

Once we start tackling this, please define specific tasks as individual issues to be tackled. Meanwhile it will remain on hold.

@GemmaTuron
Copy link
Member

Hi @DhanshreeA
Is this planned for the coming weeks or the task is still on hold?

@DhanshreeA
Copy link
Member Author

@GemmaTuron I think we now have sufficient bandwidth to fully tackle this in the coming weeks. I will prioritise this starting next week.

@DhanshreeA DhanshreeA added enhancement New feature or request and removed bug Something isn't working labels Nov 25, 2024
@DhanshreeA DhanshreeA changed the title 🐕 Batch: Improve versioning in Docker builds 🐕 Batch: Add versioning in Docker builds Nov 25, 2024
@DhanshreeA DhanshreeA moved this from On Hold to In Progress in Ersilia Model Hub Dec 16, 2024
@DhanshreeA DhanshreeA self-assigned this Dec 16, 2024
@DhanshreeA
Copy link
Member Author

DhanshreeA commented Dec 23, 2024

Updates:

  1. We have a PR here to implement tagging model images dynamically based on the time stamp from when the image build succeeds.
  2. We're adding a flag --version to the Ersilia repo to allow users to fetch specific images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants