Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added warning for unsupported Python versions (<3.8) #1544

Closed

Conversation

Samayeeta
Copy link

Description

Added a Python version check to create_cli.py to ensure users are running Python 3.8 or higher. If the version is lower, a warning message is displayed in red.

Changes to be made

Modify create_cli.py to check sys.version_info and display a warning if the version is below 3.8. The warning message is formatted in red for better visibility.

Status

The Python version check has been implemented and tested. The warning message appears correctly for Python versions below 3.8.

To do

  • Review the changes for any potential improvements.
  • Merge the PR once approved.

Is this pull request related to any open issue? If yes, replace issueID below with the issue ID

Related to #1501

@DhanshreeA
Copy link
Member

Hi @Samayeeta we already have a strong PR opened for this issue. I will deprioritise this PR for now. Thank you for taking interest in contributing to Ersilia.

@DhanshreeA DhanshreeA closed this Feb 11, 2025
@Samayeeta
Copy link
Author

Thank you for taking the time to review my pull request and for letting me know about the existing PR on this issue. I appreciate your feedback and understand the decision to prioritize the stronger PR. If you have any suggestions or specific feedback on my approach, I’d be happy to learn from it for future contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants