Websocket connection problems

[mkurkov]

Hi, I've run into several issues, trying to use escalus websocket transport.

1. Some of underlying libs (wsock) uses re:replace as template parser to create HTTP message, but if wspath has parameters with '&'s re:replace changes this to {{resource}}, so websocket connection fails.
2. Another issue with wsecli/wsock is that it's not possible to provide sec-websocket-protocol: xmpp header. Not sure if it makes sense to add wsheaders param to escalus or just hardcode somewhere in escalus_ws. My server required this, so again connection failed.
3. I saw that new version of escalus has a nice feature of user-defined transport modules, so I decided to implement one instead of patching wsock/wsecli. But some websocket specific logic works only if transport=ws, so it doesn't work with my own module name as transport. This one can be easily fixed by separating transport and module parameters.

Just thought this info could be helpful for improving escalus.

[michalwski]

Hi @mkurkov,

Thanks for the info, this is very helpful. We already thought about replacing wsock with some other, better lib. Your input makes the change more important now :)