-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bsp: New BSP for M5Stack Core (BSP-594) #452
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I make only fast review for now. I left some comments.
Would it work with my old M5Stack Core (2018.3)?
1. BSP version change to 1.0.0 2. remove useless part 3. use new I2C driver 4. use general buttons
Thanks for your review. I've updated the code based on your suggestions. PTAL and resolve the conversation if the issue has been resolved. By the way, I think the bsp will work on your old M5Stack Core, although I don't have the original M5Stack Core on hand. I checked for version changes and there were no changes that would cause compatibility issues. Perhaps you can test it with a simple lvgl demo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for much for this BSP!
I had a brief look.
I found old M5Stack Core in my drawer, I'll test it soon
1. remove esp_codec_dev 2. remove idf5 3. add i2c device deinit 4. modify description
I submitted the code according to feedback to see if the problem was improved? |
@Ocean-lhy The code changes LGTM! To fix your CI issues, please install pre-commit with Could you also please add this commit ? 3da9487 |
@tore-espressif I really appreciate your guidance. I have solved the CI problem according to your instructions. Regarding commit 3da9487, I have pulled it to make sure the CI is error-free. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ocean-lhy Thank you for all changes! LGTM
ESP-BSP Pull Request checklist
Change description