Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use driver_data instead of user_data (BSP-600) #457

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

KenVanHoeylandt
Copy link
Contributor

Change description

esp_lvgl_port was using user data to store data. When I started wrapping the drivers in my project and using the user data, this broke esp_lvgl_port.
Since LVGL9, there's a "driver data" attribute, so I refactored the existing drivers to use the driver data functions instead, which frees up the user data, which can then be left to the user.

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title Use driver_data instead of user_data Use driver_data instead of user_data (BSP-600) Dec 16, 2024
@KenVanHoeylandt
Copy link
Contributor Author

KenVanHoeylandt commented Dec 16, 2024

I had to revert some parts: This was new code from master which wasn't present in the version of esp_lvgl_port that I was using in my project. They were not part of my original changeset, so I improvised right before opening this PR.

I've reverted the relevant bits and tested it in my project (using this branch). It compiles and LVGL works.
I used a Lilygo T-Deck Plus with ESP-IDF 5.3 and LVGL 9.0 + LVGL master branch.

@tore-espressif tore-espressif requested a review from espzav January 2, 2025 13:03
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KenVanHoeylandt Thank you for this update. LGTM

@espzav espzav force-pushed the lvgl9_driver_data branch from 641fc5a to 4a75925 Compare January 2, 2025 14:46
@espzav espzav merged commit 056eb69 into espressif:master Jan 3, 2025
18 checks passed
@KenVanHoeylandt KenVanHoeylandt deleted the lvgl9_driver_data branch January 3, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants