Unify the definition of page size #49
Comments
|
Should this issue also deal with the hardcoded I would suggest removing it entirely, or possibly baking it in to the future unified definition of page size. It should now serve very little purpose with the introduction of allocation policies, prefetching and a new write buffer. @davidklaftenegger Any opinion on this? |
kostis
added a commit
that referenced
this issue
Jun 23, 2022
This constant is used for the size of a page, but was hard-coded in various places using various forms (4096, 4096UL, ...). Also, various header files used different definitions / names for it (pagesize, page_size, PAGESIZE). This commit adds a `PAGE_SIZE` constexpr and uses it in all `src` files. Addresses the biggest part of #49. (Does not deal with CACHELINE.)
Merged
kostis
added a commit
that referenced
this issue
Jun 23, 2022
This constant is used for the size of a page, but was hard-coded in various places using various forms (4096, 4096UL, ...). Also, various header files used different definitions / names for it (pagesize, page_size, PAGESIZE). This commit adds a `PAGE_SIZE` constexpr and uses it in all `src` files. Addresses the biggest part of #49. (Does not deal with CACHELINE.)
|
I have opened a new issue regarding |
kostis
added a commit
that referenced
this issue
Nov 21, 2022
This constant was used for the size of a page, but was hard-coded in various places using various forms (4096, 4096UL, ...). Also, various header files used different definitions / names for it (`pagesize`, `page_size`, `PAGESIZE`). To avoid polluting the namespace and also avoid all discussions on which header file is best to include the definition of the `PAGE_SIZE` constant, we instead pass it as a command-line definition. We also hard-code its value because we want to ensure it is an unsigned, rather than integer that the commented out code to get it from the environment or a simple 4096 would default to. Addresses the biggest part of #49. (Does not deal with CACHELINE.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related to the discussion in:
#45 (comment)
ArgoDSM page size should be defined in one module instead of appearing as separate
static constdefinitions in multiple modules, and retrieved from there where needed throughout the system.The text was updated successfully, but these errors were encountered: