Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

Can't switch to German with view > change language #1000

Closed
ChihChengLiang opened this issue Jul 19, 2016 · 10 comments
Closed

Can't switch to German with view > change language #1000

ChihChengLiang opened this issue Jul 19, 2016 · 10 comments

Comments

@ChihChengLiang
Copy link
Contributor

Node type: geth
OS: linux
Network type: main/test
Mist version: 0.8.1
branch: develop

2016-07-20 00 20 54

Can't switch to German with view > change language. At the first glance, the TAPi18n.setLanguage("de") is not behave normally.
@luclu

@luclu
Copy link
Contributor

luclu commented Jul 19, 2016

Thanks @ChihChengLiang, I linked it in your post.

@ChihChengLiang
Copy link
Contributor Author

@ChihChengLiang
Copy link
Contributor Author

de and es ignored in this commit. why?
@frozeman

@luclu
Copy link
Contributor

luclu commented Jul 20, 2016

Tschusch! I even fixed this today in this PR https://github.com/ethereum/meteor-dapp-wallet/pull/246/files

@chevdor
Copy link

chevdor commented Jul 20, 2016

Dup of #945 ?

@luclu
Copy link
Contributor

luclu commented Jul 20, 2016

Related, this stated to happen after @alexvandesande rebased your PR.
Your new PR has already partly fixed it for...

@ChihChengLiang
Copy link
Contributor Author

Check if the de and es generated by changing cdn_path from "cdn_path" : "i18n" to "cdn_path" : "/i18n" in project-tap.i18n. It works on my computer.
reference: TAPevents/i18n-bundler#2 (comment)

@luclu
Copy link
Contributor

luclu commented Jul 21, 2016

I updated the project-tap.i18n files for both repos, but still the only languages that work for me are en, fr, pt and ch. With or without your bugfix. I will recheck if I miss something in my setup later today.

@ChihChengLiang
Copy link
Contributor Author

This issue is actually unrelated to my bugfix. Instead, it's because the json in meteor-dapp-wallet app/public/i18n is not updated. If you run TAPi18n.setLanguage("de").fail(), it will show a JSON parse error which is because it fails to load de.json in app/public/i18n.
Meteor should rebuild the public i18n files on startup, it should be configured somewhere in TAPevents/i18n-bundler .

@lock
Copy link

lock bot commented Apr 1, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Apr 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants